BTW this PR adds the following to the API surface. (com.google.common.collect.ImmutableCollection.class), (com.google.common.collect.ImmutableCollection.Builder.class), (com.google.common.collect.ImmutableList.class), (com.google.common.collect.ImmutableList.Builder.class), (com.google.common.collect.UnmodifiableIterator.class), (com.google.common.collect.UnmodifiableListIterator.class),
Any objections to this ? Terry, could you explain the reason for adding this. Thanks, Cham On Tue, Sep 1, 2020 at 2:40 PM Chamikara Jayalath <chamik...@google.com> wrote: > LGTM. We can merge when tests pass. > > Thanks, > Cham > > On Tue, Sep 1, 2020 at 1:32 PM terry xian <fxian1...@yahoo.com> wrote: > >> Hi, >> >> My pull request [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and >> google_cloud_bigtable_client_core to 1.16.0 by terryxian78 · Pull Request >> #12695 · apache/beam <https://github.com/apache/beam/pull/12695> was >> there for more than 3 days. Although I've added a reviewer (lukecwik >> <https://github.com/lukecwik>), I am afraid that I missed something >> which might cause the PR not noticed (it is my first PR in Beam). I've >> asked some folks which work on spanner change review my change but need >> committee member for approval. >> >> Could someone in committee review my PR? >> >> Thanks! >> >> >> [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and >> google_cloud_bigt... >> >> Fixes https://issues.apache.org/jira/browse/BEAM-8758 R: @lukecwik CC: >> @suztomo The changes are: The main purpo... >> <https://github.com/apache/beam/pull/12695> >> >> >> >> >>
