Yes, sure. Though, I’d prefer to keep only v2 ones after a while (several releases) in case if there are no users objections.
> On 11 Sep 2020, at 19:41, Robert Bradshaw <[email protected]> wrote: > > Makes sense to me. We could keep the v1 ones around as-is with fairly low > cost, right? > > On Fri, Sep 11, 2020 at 10:13 AM Alexey Romanenko <[email protected] > <mailto:[email protected]>> wrote: > Hello, > > In Beam, there are two versions of AWS IO connectors for Java SDK - based on > AWS SDK v1 [1] and v2 [2]. For now, they are pretty equal in terms of > functionality, but since AWS SDK v2 is more modern (it's a major rewrite of > the version 1.x code base, it’s built on top of Java 8+ and adds more > features [3]), then it would be more logical to use only V2. Also, it’s not > reasonable to support two versions of similar connectors, since it’s a big > pain for us, and it will be more clear for users which package of AWS > connectors to use . > > According to this, I’d propose to deprecate all Java AWS IO connectors V1 (+ > KinesisIO which is in a different package for now) starting from Beam 2.25 > and then add new features only to V2 connectors. Bug fixes should be applied > to V2 connectors in the first order, and to V1 connectors if it’s only > necessary. > > What are the community thoughts on this? Any pros and cons that I'm missing? > > > [1] > https://github.com/apache/beam/tree/master/sdks/java/io/amazon-web-services > <https://github.com/apache/beam/tree/master/sdks/java/io/amazon-web-services> > [2] > https://github.com/apache/beam/tree/master/sdks/java/io/amazon-web-services2 > <https://github.com/apache/beam/tree/master/sdks/java/io/amazon-web-services2> > [3] https://docs.aws.amazon.com/sdk-for-java/v2/developer-guide/welcome.html > <https://docs.aws.amazon.com/sdk-for-java/v2/developer-guide/welcome.html> > >
