I think that output is still incorrect for :sdks:java:io:expansion-service, there should be both shaded and unshaded in ./sdks/java/io/expansion-service/build/libs
On Tue, Sep 29, 2020 at 1:08 PM Tyson Hamilton <[email protected]> wrote: > Or, possibly that PR already fixed the issue. Could you sync, retry again? > Here is what I found after running the gradle task you mentioned: > > ttysonjh@tysonjh:~/Development/beam$ find . -name > "*expansion-service*SNAPSHOT*" > > ./sdks/java/expansion-service/build/libs/beam-sdks-java-expansion-service-2.26.0-SNAPSHOT.jar > > ./sdks/java/io/expansion-service/build/libs/beam-sdks-java-io-expansion-service-2.26.0-SNAPSHOT-unshaded.jar > > ./sdks/java/io/expansion-service/build/libs/beam-sdks-java-io-expansion-service-2.26.0-SNAPSHOT-tests-unshaded.jar > > ./sdks/java/io/expansion-service/build/distributions/expansion-service-2.26.0-SNAPSHOT.tar > > ./sdks/java/io/expansion-service/build/distributions/expansion-service-2.26.0-SNAPSHOT.zip > > > On Tue, Sep 29, 2020 at 12:59 PM Tyson Hamilton <[email protected]> > wrote: > >> Hm. It sounds like it is possibly related to the gradle upgrade to 6? I >> had a similar issue that I fixed for the Java nightly snapshot build in >> PR#12947 (https://github.com/apache/beam/pull/12947). It may require >> similar changes to the gradle.build file to generate the jar. >> >> On Tue, Sep 29, 2020 at 8:20 AM Chamikara Jayalath <[email protected]> >> wrote: >> >>> +Brian Hulette <[email protected]> for any follow ups here since I'll >>> be OOO for a few days. >>> >>> Thanks, >>> Cham >>> >>> On Mon, Sep 28, 2020 at 10:34 PM Chamikara Jayalath < >>> [email protected]> wrote: >>> >>>> Hi, >>>> >>>> I just noticed that the result jars produced by command "./gradlew >>>> :sdks:java:io:expansion-service:build" went from both shaded [1] and >>>> unshaded [2] jars for Beam 2.24.0 branch to just the unshaded jar [3] for >>>> Beam 2.25.0 branch. >>>> >>>> Does anyone know what resulted in this behaviour change ? >>>> >>>> Also, does this mean that the jars released for Beam 2.25.0 will be >>>> different ? (if so I believe that will break cross-language transforms that >>>> will try to download the shaded jar for expansion). >>>> >>>> [1] beam-sdks-java-io-expansion-service-2.24.0-SNAPSHOT.jar >>>> [2] beam-sdks-java-io-expansion-service-2.24.0-SNAPSHOT-unshaded.jar >>>> [3] beam-sdks-java-io-expansion-service-2.25.0-SNAPSHOT-unshaded.jar >>>> >>>
