Thanks Alex!

Based on the standard output, it looks like the None is returned by one of
the failure paths when the environment is considered not in a notebook.

There could be a race condition when tests are running in parallel and
modifying the global instance ib.current_env().
In that case, a patch in the test to use a mocked `is_in_notebook` check
should be added.

Filed https://issues.apache.org/jira/browse/BEAM-11025 and sent out
https://github.com/apache/beam/pull/13020.

On Tue, Oct 6, 2020 at 9:40 AM Alex Amato <[email protected]> wrote:

> I am seeing this failure in the precommit of a PR
> <https://github.com/apache/beam/pull/13011> where I am trying to update
> the Dataflow container reference.
>
> I would have filed a JIRA issue as well, but I can't seem to load the
> website right now. Is this test known to be flakey or something? Has it
> regressed? I don't suspect this interactive runner test is using the new
> container referenced in the PR, sio I didn't think this PR would affect
> this test. Though I could be wrong.
>
> I will rerun for now.
> Please let me know if you have any suggestions
>
> Details
> ---
>
> https://ci-beam.apache.org/job/beam_PreCommit_Python_Phrase/2241/testReport/junit/apache_beam.runners.interactive.display.pcoll_visualization_test/PCollectionVisualizationTest/test_dynamic_plotting_return_handle/
>
> Error Message
>
> AssertionError: None is not an instance of <class 'timeloop.app.Timeloop'>
>
> Stacktrace
>
> self = 
> <apache_beam.runners.interactive.display.pcoll_visualization_test.PCollectionVisualizationTest
>  testMethod=test_dynamic_plotting_return_handle>
>
>     def test_dynamic_plotting_return_handle(self):
>       h = pv.visualize(
>           self._stream, dynamic_plotting_interval=1, display_facets=True)
> >     self.assertIsInstance(h, timeloop.Timeloop)
> E     AssertionError: None is not an instance of <class 
> 'timeloop.app.Timeloop'>
>
> apache_beam/runners/interactive/display/pcoll_visualization_test.py:93: 
> AssertionError
>
> Standard Output
>
> <IPython.core.display.HTML object>
> <IPython.core.display.HTML object>
>    0
> 0  0
> 1  1
> 2  2
> 3  3
> 4  4
>
>

Reply via email to