Thanks, Ning and Ahmet. +1 (binding) Approve the release.
On Fri, Oct 16, 2020 at 1:34 PM Ning Kang <[email protected]> wrote: > Sorry, if you cannot see the missing thread history in the previous > thread, here is another copy: > > On Fri, Oct 16, 2020 at 9:55 AM Robert Bradshaw <[email protected]> > wrote: > >> Thanks. >> >> +1 (binding) to this release. >> >> On Thu, Oct 15, 2020 at 7:06 PM Ahmet Altay <[email protected]> wrote: >> >>> Here you go: >>> https://dist.apache.org/repos/dist/dev/beam/extensions/jupyterlab-sidepanel/v1.0.0/ >>> >>> On Thu, Oct 15, 2020 at 5:11 PM Robert Bradshaw <[email protected]> >>> wrote: >>> >>>> If we can stage the sources to dist/dev that sounds good to me. >>>> >>>> On Thu, Oct 15, 2020 at 4:57 PM Ning Kang <[email protected]> wrote: >>>> >>>>> +1 to Ahmet's suggestion. >>>>> >>>>> I've taken a look at the process >>>>> <https://docs.google.com/document/d/1ztEoyGkqq9ie5riQxRtMuBu3vb6BUO91mSMn1PU0pDA/edit#heading=h.uqiyxx7oert8> >>>>> used >>>>> by vendored artifacts and summarized below commands to stage the source >>>>> code to dist/dev >>>>> >>>>> extension=jupyterlab-sidepanel >>>>> >>>>> version=v1.0.0 >>>>> >>>>> tag=${extension}-${version} >>>>> >>>>> >>>>> svn co https://dist.apache.org/repos/dist/dev/beam >>>>> >>>>> mkdir -p beam/extensions/${extension}/${version} >>>>> >>>>> pushd beam/extensions/${extension}/${version} >>>>> >>>>> curl -o apache-beam-${tag}-source-release.zip https:// >>>>> github.com/apache/beam/archive/${tag}.zip >>>>> <http://github.com/apache/beam/archive/$%7Btag%7D.zip> >>>>> >>>>> gpg --armor --detach-sig apache-beam-${tag}-source-release.zip >>>>> >>>>> sha512sum apache-beam-${tag}-source-release.zip > apache-beam-${tag}- >>>>> source-release.zip.sha512 >>>>> >>>>> # If sha512sum command is not found, on mac, run brew install >>>>> coreutils; >>>>> >>>>> # on linux, run apt-get install coreutils >>>>> >>>>> popd >>>>> >>>>> pushd beam >>>>> >>>>> # For the first time adding the directory with its contents >>>>> >>>>> svn add extensions >>>>> >>>>> # For future versions, use below to add >>>>> >>>>> # svn add extensions/${extension}/${version} >>>>> >>>>> svn commit >>>>> >>>>> Please feel free to comment on the directory structure. >>>>> >>>>> Ahmet, if everything looks good, could you please help me execute the >>>>> commands with your GPG key to stage the source to dist/dev? >>>>> And once we publish the extension to NPM, we'll move the source from >>>>> dist/dev to dist/release following the same process >>>>> <https://docs.google.com/document/d/1ztEoyGkqq9ie5riQxRtMuBu3vb6BUO91mSMn1PU0pDA/edit#heading=h.kzrr7s34eja2> >>>>> to >>>>> vendored artifact's releases. >>>>> >>>>> I'll document the release process with release history in the Beam >>>>> repo once the release is done. >>>>> >>>>> Thanks! >>>>> >>>>> On Thu, Oct 15, 2020 at 1:06 PM Ahmet Altay <[email protected]> wrote: >>>>> >>>>>> This is similar to the vendored dependencies release. For that we >>>>>> vote on the artifacts. commit hash, and staged source distribution on >>>>>> dist/dev[1]. And then the same source distribution is promoted to >>>>>> dist/release [2]. We can follow the same process and stage a source >>>>>> distribution to dist. >>>>>> >>>>>> [1] >>>>>> https://lists.apache.org/thread.html/rea4a27c47529a27936ab2c51162c8e532b8b625c4d70c4f7f485c7cd%40%3Cdev.beam.apache.org%3E >>>>>> [2] https://dist.apache.org/repos/dist/release/beam/vendor/ >>>>>> >>>>>> On Thu, Oct 15, 2020 at 12:17 PM Robert Bradshaw <[email protected]> >>>>>> wrote: >>>>>> >>>>>>> I'm thinking specifically of >>>>>>> >>>>>>> >>>>>>> https://incubator.apache.org/guides/distribution.html#release_platforms >>>>>>> >>>>>>> In addition to the Apache mirror system incubating projects may >>>>>>> distribute artifacts on other platforms as long as they follow these >>>>>>> general guidelines: >>>>>>> * Source releases must be placed in the Apache mirror system. >>>>>>> >>>>>>> >>>>>>> On Thu, Oct 15, 2020 at 12:05 PM Ning Kang <[email protected]> wrote: >>>>>>> >>>>>>>> Thanks Robert, I didn't know the existence of this document. >>>>>>>> >>>>>>>> Looks like the only thing potentially missing is the incubation >>>>>>>> disclaimer. >>>>>>>> NPM should be the only channel for distribution. And normally, a >>>>>>>> jupyter user would install extensions through `jupyter` commands. They >>>>>>>> wouldn't even use the `npm` command directly. >>>>>>>> >>>>>>>> Looking at >>>>>>>> https://incubator.apache.org/guides/branding.html#disclaimers, >>>>>>>> since this extension is part of Beam and we are not incubating >>>>>>>> something >>>>>>>> new, we might not even need an incubation disclaimer. >>>>>>>> The same applies to pypi: https://pypi.org/project/apache-beam/ >>>>>>>> >>>>>>>> What do you think? >>>>>>>> >>>>>>>> >>>>>>>> On Thu, Oct 15, 2020 at 11:05 AM Robert Bradshaw < >>>>>>>> [email protected]> wrote: >>>>>>>> >>>>>>>>> The code looks good to me. Do we also need to do a >>>>>>>>> corresponding source release in the apache distribution channels, or >>>>>>>>> is a >>>>>>>>> vote on a specific github commit sufficient? >>>>>>>>> >>>>>>>>> (Looking at >>>>>>>>> https://incubator.apache.org/guides/distribution.html#npm) >>>>>>>>> >>>>>>>> > On Fri, Oct 16, 2020 at 1:29 PM Ning Kang <[email protected]> wrote: > >> Thanks Ahmet and Robert! Please see the quote attached for the missing >> history of discussion and vote from Robert, sorry for the confusion. >> Based on Robert's suggestion, we updated the original vote thread with a >> new link to "the official Apache source release to be deployed to >> dist.apache.org [4]". >> The whole vote thread is copied with the update as below. No source or >> binary change. the vote will be open throughout the weekend: >> >> Please review the release of the following jupyter labextension >> (TypeScript node package) for running Beam notebooks in JupyterLab: >> * apache-beam-jupyterlab-sidepanel >> >> Hi everyone, >> Please review and vote on the release candidate #1 for the version 1.0.0, >> as follows: >> [ ] +1, Approve the release >> [ ] -1. Do not approve the release (please provide specific comments) >> >> The complete staging area is available for your review, which includes: >> * the assets (only the >> `sdks/python/apache_beam/runners/interactive/extensions/apache-beam-jupyterlab-sidepanel` >> sub directory) to be published to npmjs.com [1] >> * commit hash "b7ae7bb1dc28a7c8f26e9f48682e781a74e2d3c4" [2] >> * NPM package will be signed by NPM once published; the pgp machinery [3] >> * the official Apache source release to be deployed to dist.apache.org >> [4] >> >> Additional details: >> * to install the package before it being published, install it locally by >> cloning the Beam repo or downloading the assets: >> >> git checkout jupyterlab-sidepanel-v1.0.0 -b some-branch # if cloning the >> repo, do this step >> >> pushd sdks/python/apache_beam/runners/interactive/extensions/apache-beam- >> jupyterlab-sidepanel >> >> jlpm >> >> jlpm build >> >> jupyter labextension link . >> * screenshots of the extension [5] >> * a publish dry run: >> >> npm notice === Tarball Details === >> >> npm notice name: apache-beam-jupyterlab-sidepanel >> >> npm notice version: 1.0.0 >> >> npm notice package size: 19.8 kB >> >> npm notice unpacked size: 101.9 kB >> >> npm notice shasum: 7f896de0d6e587aab2bef348a6e94f95f75f280f >> >> npm notice integrity: sha512-hdkn2Ni2S0roY[...]ShMK2/MAbQvyQ== >> >> npm notice total files: 51 >> >> npm notice >> >> + [email protected] >> >> The vote will be open for at least 72 hours. It is adopted by majority >> approval, with at least 3 PMC affirmative votes. >> >> Thanks! >> >> [1] >> https://github.com/apache/beam/releases/tag/jupyterlab-sidepanel-v1.0.0 >> [2] >> https://github.com/apache/beam/commit/b7ae7bb1dc28a7c8f26e9f48682e781a74e2d3c4 >> [3] https://blog.npmjs.org/post/172999548390/new-pgp-machinery >> [4] >> https://dist.apache.org/repos/dist/dev/beam/extensions/jupyterlab-sidepanel/v1.0.0/ >> <https://docs.google.com/document/d/1aKK8TzSrl8WiG0K4v9xZEfLMCinuGqRlMOyb7xOhgy4/edit#heading=h.he7se5yxfo7> >> [5] >> https://docs.google.com/document/d/1aKK8TzSrl8WiG0K4v9xZEfLMCinuGqRlMOyb7xOhgy4/edit#heading=h.he7se5yxfo7 >> >> On Fri, Oct 9, 2020 at 1:58 PM Ning Kang <[email protected]> wrote: >> >>> To Pablo, >>> >>> The public key in use by NPM can be found in this blog "[3] >>> https://blog.npmjs.org/post/172999548390/new-pgp-machinery";. A direct >>> link: https://keybase.io/npmregistry/pgp_keys.asc >>> Quoted from the blog: >>> >>>> We’ve also chosen to use Keybase >>>> <https://t.umblr.com/redirect?z=https%3A%2F%2Fkeybase.io&t=Y2YyM2E5ZDdhZmM5OTU3ZmQ0ODg0ZTJlODJhZGRlZDg4N2UyYzFkYyxsRDlvMmNtVg%3D%3D&b=t%3AnXsLs1P4AptPf1fBr_nFxw&p=https%3A%2F%2Fblog.npmjs.org%2Fpost%2F172999548390%2Fnew-pgp-machinery&m=1&ts=1602276950> >>>> to >>>> publicize our PGP key and give you confidence that the npm registry you >>>> install from is the same registry that’s signing packages. Our account on >>>> Keybase is npmregistry >>>> <https://t.umblr.com/redirect?z=https%3A%2F%2Fkeybase.io%2Fnpmregistry&t=M2Y4OWQ5M2YxOTNjOGYzNzI5Yzc2ZjE2YTVkY2MxMjgxNjYxNDdhMCxsRDlvMmNtVg%3D%3D&b=t%3AnXsLs1P4AptPf1fBr_nFxw&p=https%3A%2F%2Fblog.npmjs.org%2Fpost%2F172999548390%2Fnew-pgp-machinery&m=1&ts=1602276950> >>>> . >>> >>> Keybase can be found here: https://keybase.io/ >>> >>> Thanks! >>> Ning. >>> >>> On Fri, Oct 9, 2020 at 1:53 PM Pablo Estrada <[email protected]> wrote: >>> >>>> +1 >>>> I installed the extension and reviewed it as well. >>>> >>>> I have a question: You mention that NPM will sign the package. What key >>>> will it use? We may need to upload your pgp key to the Beam list of keys? >>>> Thanks Ning! >>>> -P. >>>> >>>> On Tue, Oct 6, 2020 at 2:57 PM Ning Kang <[email protected]> wrote: >>>> >>>>> Please review the release of the following jupyter labextension >>>>> (TypeScript node package) for running Beam notebooks in JupyterLab: >>>>> * apache-beam-jupyterlab-sidepanel >>>>> >>>>> Hi everyone, >>>>> Please review and vote on the release candidate #1 for the version >>>>> 1.0.0, as follows: >>>>> [ ] +1, Approve the release >>>>> [ ] -1. Do not approve the release (please provide specific comments) >>>>> >>>>> The complete staging area is available for your review, which includes: >>>>> * the assets (only the >>>>> `sdks/python/apache_beam/runners/interactive/extensions/apache-beam-jupyterlab-sidepanel` >>>>> sub directory) to be published to npmjs.com [1] >>>>> * commit hash "b7ae7bb1dc28a7c8f26e9f48682e781a74e2d3c4" [2] >>>>> * package will be signed by NPM once published; the pgp machinery [3] >>>>> >>>>> Additional details: >>>>> * to install the package before it being published, install it locally >>>>> by cloning the Beam repo or downloading the assets: >>>>> >>>>> git checkout jupyterlab-sidepanel-v1.0.0 -b some-branch # if cloning >>>>> the repo, do this step >>>>> >>>>> pushd sdks/python/apache_beam/runners/interactive/extensions/apache- >>>>> beam-jupyterlab-sidepanel >>>>> >>>>> jlpm >>>>> >>>>> jlpm build >>>>> >>>>> jupyter labextension link . >>>>> * screenshots of the extension [4] >>>>> * a publish dry run: >>>>> >>>>> npm notice === Tarball Details === >>>>> >>>>> npm notice name: apache-beam-jupyterlab-sidepanel >>>>> >>>>> npm notice version: 1.0.0 >>>>> >>>>> npm notice package size: 19.8 kB >>>>> >>>>> npm notice unpacked size: 101.9 kB >>>>> >>>>> npm notice shasum: 7f896de0d6e587aab2bef348a6e94f95f75f280f >>>>> >>>>> npm notice integrity: sha512-hdkn2Ni2S0roY[...]ShMK2/MAbQvyQ== >>>>> >>>>> npm notice total files: 51 >>>>> >>>>> npm notice >>>>> >>>>> + [email protected] >>>>> >>>>> The vote will be open for at least 72 hours. It is adopted by majority >>>>> approval, with at least 3 PMC affirmative votes. >>>>> >>>>> Thanks! >>>>> >>>>> [1] >>>>> https://github.com/apache/beam/releases/tag/jupyterlab-sidepanel-v1.0.0 >>>>> [2] >>>>> https://github.com/apache/beam/commit/b7ae7bb1dc28a7c8f26e9f48682e781a74e2d3c4 >>>>> [3] https://blog.npmjs.org/post/172999548390/new-pgp-machinery >>>>> [4] >>>>> https://docs.google.com/document/d/1aKK8TzSrl8WiG0K4v9xZEfLMCinuGqRlMOyb7xOhgy4/edit#heading=h.he7se5yxfo7 >>>>> >>>>
