> We should update the release guide to make this explicit for the person preparing the release so this does not happen again and eventually include some validation for this in the build.
Instructions in the release guide can be easily missed. We should prioritize adding a version check to all the relevant build scripts so it becomes a hard failure if Java 11 is used. On Mon, Oct 19, 2020 at 3:11 PM Robin Qiu <[email protected]> wrote: > Thank you all for the feedback! I will work on a RC2 to address these > problems. > > On Mon, Oct 19, 2020 at 7:38 AM Ismaël Mejía <[email protected]> wrote: > >> -1 >> >> > * Java artifacts were built with Maven 3.5.3 and OpenJDK/Oracle JDK >> 11.0.8. >> >> As from discussion on 2.24.0 RC1 we MUST build Java artifacts with Java 8 >> otherwise we will not have guaranteed compatibility with Java 8. >> We should update the release guide to make this explicit for the person >> preparing the release so this does not happen again and eventually include >> some validation for this in the build. >> >> I validated that this is broken the same way as before by running a >> pipeline with Direct runner using the 2.25.0 jars inside of a Java 8 docker. >> The Exception is the same. >> >> 2020-10-19 16:14:23,427 [direct-runner-worker] ERROR >> org.apache.beam.runners.direct.DirectTransformExecutor - Error occurred >> within org.apache.beam.runners.direct.DirectTransformExecutor@6babef80 >> java.lang.NoSuchMethodError: >> java.nio.ByteBuffer.clear()Ljava/nio/ByteBuffer; >> at >> org.apache.beam.sdk.util.BufferedElementCountingOutputStream.outputBuffer(BufferedElementCountingOutputStream.java:197) >> at >> org.apache.beam.sdk.util.BufferedElementCountingOutputStream.flush(BufferedElementCountingOutputStream.java:180) >> at >> org.apache.beam.sdk.util.BufferedElementCountingOutputStream.finish(BufferedElementCountingOutputStream.java:119) >> at >> org.apache.beam.sdk.coders.IterableLikeCoder.encode(IterableLikeCoder.java:127) >> at >> org.apache.beam.sdk.coders.IterableLikeCoder.encode(IterableLikeCoder.java:60) >> at org.apache.beam.sdk.coders.Coder.encode(Coder.java:136) >> >> >> On Sat, Oct 17, 2020 at 3:57 AM Ahmet Altay <[email protected]> wrote: >> >>> I verified python quickstarts. There is a minor issue and I will update >>> my vote after that. >>> >>> Python batch pipelines on Dataflow are failing with the following error: >>> "RuntimeError: Beam SDK base version 2.25.0 does not match Dataflow Python >>> worker version 2.25.0.dev. Please check Dataflow worker startup logs >>> and make sure that correct version of Beam SDK is installed." >>> >>> Same issue happened during 2.24.0 and was fixed quickly. We may need to >>> update the release guide to prevent this error in the future. (/cc +Daniel >>> Oliveira <[email protected]> and +Valentyn Tymofieiev >>> <[email protected]> fixed the issue for 2.24.0). >>> >>> Ahmet >>> >>> On Fri, Oct 16, 2020 at 2:36 PM Robin Qiu <[email protected]> wrote: >>> >>>> Hi everyone, >>>> Please review and vote on the release candidate #1 for the version >>>> 2.25.0, as follows: >>>> [ ] +1, Approve the release >>>> [ ] -1, Do not approve the release (please provide specific comments) >>>> >>>> >>>> The complete staging area is available for your review, which includes: >>>> * JIRA release notes [1], >>>> * the official Apache source release to be deployed to dist.apache.org >>>> [2], which is signed with the key with fingerprint >>>> AD70476B9D1AF3EFEC2208165952E71AACAF911D [3], >>>> * all artifacts to be deployed to the Maven Central Repository [4], >>>> * source code tag "v2.25.0-RC1" [5], >>>> * website pull request listing the release [6], publishing the API >>>> reference manual [7], and the blog post [8]. >>>> * Java artifacts were built with Maven 3.5.3 and OpenJDK/Oracle JDK >>>> 11.0.8. >>>> * Python artifacts are deployed along with the source release to the >>>> dist.apache.org [2]. >>>> * Validation sheet with a tab for 2.25.0 release to help with >>>> validation [9]. >>>> * Docker images published to Docker Hub [10]. >>>> >>>> The vote will be open for at least 72 hours. It is adopted by majority >>>> approval, with at least 3 PMC affirmative votes. >>>> >>>> Thanks, >>>> Robin >>>> >>>> [1] >>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12319527&version=12347147 >>>> [2] https://dist.apache.org/repos/dist/dev/beam/2.25.0/ >>>> [3] https://dist.apache.org/repos/dist/release/beam/KEYS >>>> [4] >>>> https://repository.apache.org/content/repositories/orgapachebeam-1139/ >>>> [5] https://github.com/apache/beam/tree/v2.25.0-RC1 >>>> [6] https://github.com/apache/beam/pull/13130 >>>> [7] https://github.com/apache/beam-site/pull/608 >>>> [8] https://github.com/apache/beam/pull/13131 >>>> [9] >>>> https://docs.google.com/spreadsheets/d/1qk-N5vjXvbcEk68GjbkSZTR8AGqyNUM-oLFo_ZXBpJw/edit#gid=1494345946 >>>> [10] https://hub.docker.com/search?q=apache%2Fbeam&type=image >>>> >>>
