+1 (binding). I verified the release artifacts and signatures, and tried a couple of Python pipelines from an install of a wheel in a fresh virtual environment. All looks good to me.
On Thu, Oct 22, 2020 at 4:54 PM Tyson Hamilton <[email protected]> wrote: > > +1 > > I went through the Nexmark queries and validated the results. > > On Thu, Oct 22, 2020 at 4:43 PM Pablo Estrada <[email protected]> wrote: >> >> +1 (binding) >> Validated Java quickstart for Direct, Dataflow, Spark runners. >> Tried out a few interactive queries on InteractiveRunner on Ipython. >> Best >> -P. >> >> On Thu, Oct 22, 2020 at 4:27 PM Valentyn Tymofieiev <[email protected]> >> wrote: >>> >>> +1. >>> >>> Verified the internal container images for Dataflow and verified that the >>> release artifacts are not installable on Python 2 and Python 3.5 (which >>> could otherwise break Beam Py2/Py3.5 users who don't set an upper bound on >>> Beam). >>> >>> On Wed, Oct 21, 2020 at 1:14 PM Chamikara Jayalath <[email protected]> >>> wrote: >>>> >>>> +1 (non-binding). >>>> >>>> Validated Java quickstart for Direct/Dataflow runners and x-lang Kafka/SQL. >>>> >>>> Thanks, >>>> Cham >>>> >>>> On Wed, Oct 21, 2020 at 6:03 AM Ismaël Mejía <[email protected]> wrote: >>>>> >>>>> Unrelated to the vote, but related to the Java 8/11 issue. >>>>> >>>>> We have some 'forward' compatibility tests that rely on the Beam daily >>>>> SNAPSHOT jars >>>>> and they starting failing two days ago, it seems the SNAPSHOTs are now >>>>> built also with Java 11 (not sure if related) >>>>> >>>>> Filled https://issues.apache.org/jira/browse/BEAM-11080 in case someone >>>>> can take a look >>>>> >>>>> The SNAPSHOTs should be built with Java 8 too. We use these for forward >>>>> compatibility tests and they have helped us find multiple regressions in >>>>> the >>>>> past. >>>>> >>>>> On Wed, Oct 21, 2020 at 3:42 AM Ahmet Altay <[email protected]> wrote: >>>>>> >>>>>> +1 - I verified python quickstarts. >>>>>> >>>>>> On Tue, Oct 20, 2020 at 11:36 AM Robin Qiu <[email protected]> wrote: >>>>>>> >>>>>>> Hi everyone, >>>>>>> Please review and vote on the release candidate #2 for the version >>>>>>> 2.25.0, as follows: >>>>>>> [ ] +1, Approve the release >>>>>>> [ ] -1, Do not approve the release (please provide specific comments) >>>>>>> >>>>>>> >>>>>>> The complete staging area is available for your review, which includes: >>>>>>> * JIRA release notes [1], >>>>>>> * the official Apache source release to be deployed to dist.apache.org >>>>>>> [2], which is signed with the key with fingerprint >>>>>>> AD70476B9D1AF3EFEC2208165952E71AACAF911D [3], >>>>>>> * all artifacts to be deployed to the Maven Central Repository [4], >>>>>>> * source code tag "v2.25.0-RC2" [5], >>>>>>> * website pull request listing the release [6], publishing the API >>>>>>> reference manual [7], and the blog post [8]. >>>>>>> * Java artifacts were built with Maven 3.5.3 and OpenJDK 1.8.0 >>>>>>> * Python artifacts are deployed along with the source release to the >>>>>>> dist.apache.org [2]. >>>>>>> * Validation sheet with a tab for 2.25.0 release to help with >>>>>>> validation [9]. >>>>>>> * Docker images published to Docker Hub [10]. >>>>>>> >>>>>>> The vote will be open for at least 72 hours. It is adopted by majority >>>>>>> approval, with at least 3 PMC affirmative votes. >>>>>>> >>>>>>> Thanks, >>>>>>> Robin >>>>>>> >>>>>>> [1] >>>>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12319527&version=12347147 >>>>>>> [2] https://dist.apache.org/repos/dist/dev/beam/2.25.0/ >>>>>>> [3] https://dist.apache.org/repos/dist/release/beam/KEYS >>>>>>> [4] >>>>>>> https://repository.apache.org/content/repositories/orgapachebeam-1142 >>>>>>> [5] https://github.com/apache/beam/tree/v2.25.0-RC2 >>>>>>> [6] https://github.com/apache/beam/pull/13130 >>>>>>> [7] https://github.com/apache/beam-site/pull/608 >>>>>>> [8] https://github.com/apache/beam/pull/13131 >>>>>>> [9] >>>>>>> https://docs.google.com/spreadsheets/d/1qk-N5vjXvbcEk68GjbkSZTR8AGqyNUM-oLFo_ZXBpJw/edit#gid=1494345946 >>>>>>> [10] https://hub.docker.com/search?q=apache%2Fbeam&type=image
