Oh I see. Thanks for the clarification, Kenn! Yeah the CombineFn LOGICAL_AND is to be implemented.
On Fri, Nov 13, 2020 at 10:00 AM Kenneth Knowles <[email protected]> wrote: > Some clarification: LOGICAL_AND is a ZetaSQL/BigQuery aggregate function: > https://cloud.google.com/bigquery/docs/reference/standard-sql/functions-and-operators#logical_and > > So it needs to be implemented as a CombineFn. Here are some example PRs > that do similar things: https://github.com/apache/beam/pulls?q=BIT_OR > > Kenn > > On Thu, Nov 12, 2020 at 12:48 PM Rui Wang <[email protected]> wrote: > >> Or the question is, which BeamSQL dialect you are using? >> >> >> -Rui >> >> On Thu, Nov 12, 2020 at 12:41 PM Robin Qiu <[email protected]> wrote: >> >>> Hi Sonam, AND operator is already defined by Calcite and the mapping is >>> here: >>> https://github.com/apache/beam/blob/816017e44e3209d334f4f3b2bc3fa829663c530e/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/SqlOperatorMappingTable.java#L39. >>> Is this what you are looking for? >>> >>> On Thu, Nov 12, 2020 at 12:00 PM Kyle Weaver <[email protected]> >>> wrote: >>> >>>> If you're defining a new built-in function in ZetaSQL, you can define >>>> an operator for it here: >>>> https://github.com/apache/beam/blob/master/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/SqlOperators.java >>>> >>>> Then add the operator the table here: >>>> https://github.com/apache/beam/blob/master/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/SqlOperatorMappingTable.java >>>> >>>> On Thu, Nov 12, 2020 at 11:14 AM Sonam Ramchand < >>>> [email protected]> wrote: >>>> >>>>> There is no LOGICAL_AND operator in SqlStdOperatorTable, is there any >>>>> other way to implement LOGICAL_AND? >>>>> >>>>> -- >>>>> >>>>> Regards, >>>>> *Sonam* >>>>> Software Engineer >>>>> Mobile: +92 3088337296 <+92%20308%208337296> >>>>> >>>>> <http://venturedive.com/> >>>>> >>>>
