Are you referring to a "Flink Gauge" or a "Beam Gauge"? Are you suggesting to package it as a "Flink Histogram?" (i.e. A Flink runner specific concept of Histograms) If so, seems fine and I have no comment here.
FWIW, I proposed a "Beam Histogram" metric (bucket counts). https://s.apache.org/beam-histogram-metrics (No runner, implements this, and most likely I will not be pursuing this further, due to a change of priority/interest around the meric I was interested in using this for). I was intending to use it for a specific set of metrics metric (No plans to provide a User defined Histogram Metric API) https://s.apache.org/beam-gcp-debuggability I don't think we should pursue any plans to package "Beam Distributions" as "Beam Histograms". As a "Beam Histogram" is essential several counters (one for each bucket). Changing all usage of beam.distribution to a "Beam Histograms" would have performance implications, and is not advised. If at some point "Beam Histograms" are implemented, migrating the usage of Metrics.distribution to histogram should be done on an individual basis. <https://s.apache.org/beam-histogram-metrics> On Thu, Nov 19, 2020 at 5:47 PM Robert Bradshaw <[email protected]> wrote: > Guage certainly seems wrong for DistributionResult. Yes, using a > Histogram would be a welcome PR. > > On Thu, Nov 19, 2020 at 12:58 PM Kyle Weaver <[email protected]> wrote: > > > > What are the advantages of using a Histogram instead of a Gauge? > > > > Also, check out this design doc for adding histogram metrics to Beam if > you haven't already: http://s.apache.org/beam-metrics-api (Not sure what > the current status is.) > > > > On Wed, Nov 18, 2020 at 1:37 PM Richard Moorhead < > [email protected]> wrote: > >> > >> Beam's DistributionResult is implemented as a Gauge within the Flink > runner. Can someone explain the rationale behind this? Would a PR to > utilize a Histogram be acceptable? >
