Thank you all for fixing this!

> On 8 Mar 2021, at 21:06, Ankur Goenka <[email protected]> wrote:
> 
> The fix PR https://github.com/apache/beam/pull/14148 
> <https://github.com/apache/beam/pull/14148> which upgrades the error prone 
> version to 2.3.4 with failing checks disabled seems to be working fine and is 
> merged.
> 
> Please sync to head and try again.
> 
> On Mon, Mar 8, 2021 at 8:26 AM Daniel Collins <[email protected] 
> <mailto:[email protected]>> wrote:
> Hello all,
> 
> Can we make progress on either updating the version or rolling back 
> https://github.com/apache/beam/commit/dfeda2ab1dbebd8446766fae0cafb314ec29920f
>  
> <https://github.com/apache/beam/commit/dfeda2ab1dbebd8446766fae0cafb314ec29920f>?
>  This is blocking any and all PRs from being submitted.
> 
> Thanks,
> 
> Daniel
> 
> On Thu, Mar 4, 2021 at 6:52 PM Shehzaad Nakhoda <[email protected] 
> <mailto:[email protected]>> wrote:
> Hi Ankur
> 
> I've created a PR https://github.com/apache/beam/pull/14148 
> <https://github.com/apache/beam/pull/14148> to see if this upgrade might help.
> 
> Would be great to know if you can repro locally on Ubuntu. I'm on a Mac.
> 
> thanks
> --shehzaad
> 
> 
> 
> On Thu, Mar 4, 2021 at 3:32 PM Ankur Goenka <[email protected] 
> <mailto:[email protected]>> wrote:
> The :sdks:java:core:compileJava is only failing for ubuntu on error prone. 
> I am trying to repro it locally and can try updating the error prone version 
> to see if it helps.
> 
> On Thu, Mar 4, 2021 at 3:26 PM Shehzaad Nakhoda <[email protected] 
> <mailto:[email protected]>> wrote:
> It appears this is an issue in errorprone:2.3.1 which has been fixed in 2.3.2.
> 
> https://github.com/google/error-prone/issues/1091 
> <https://github.com/google/error-prone/issues/1091>
> 
> We currently use 2.3.1 (set in BeamModulePlugin.groovy). Should we upgrade to 
> 2.3.2?
> 
> 
> On Thu, Mar 4, 2021 at 10:03 AM Kyle Weaver <[email protected] 
> <mailto:[email protected]>> wrote:
> I don't think this is just a flake; it seems Github actions Java tests are 
> permared right now. I filed a JIRA for it: 
> https://issues.apache.org/jira/browse/BEAM-11921 
> <https://issues.apache.org/jira/browse/BEAM-11921>
> 
> 
> 
> 
> On Thu, Mar 4, 2021 at 9:19 AM Robert Bradshaw <[email protected] 
> <mailto:[email protected]>> wrote:
> I've noticed this sometimes for Python as well: Jenkins is happy with the 
> exact same tests that Github checks fails on. 
> 
> On Thu, Mar 4, 2021 at 8:40 AM Alexey Romanenko <[email protected] 
> <mailto:[email protected]>> wrote:
> Hi,
> 
> Does anyone know why some Java Tests, that run as Github checks, fail? For 
> example for this PR [1], this [2] and this [3] checks, whenever other passed 
> and there are no fails for Jenkins jobs.
> I noticed that the same checks fail for some other latest PRs as well. Is it 
> coincidence?
> 
> [1] https://github.com/apache/beam/pull/13914 
> <https://github.com/apache/beam/pull/13914>
> [2] https://github.com/apache/beam/pull/13914/checks?check_run_id=2029368988 
> <https://github.com/apache/beam/pull/13914/checks?check_run_id=2029368988>
> [3] https://github.com/apache/beam/pull/13914/checks?check_run_id=2029369164 
> <https://github.com/apache/beam/pull/13914/checks?check_run_id=2029369164>
> 
> 
> 
> 
> -- 
> Shehzaad Nakhoda
> CTO
> USA/WhatsApp: +1 6502085107 <tel:(650)%20208-5107>
> PAK: +92 3082654179 <tel:+92%20308%202654179>
>  <http://venturedive.com/>

Reply via email to