Sounds good. I imagine the tests are set up that way so that users can run tests locally on platforms that do not support epoll. Will the change in shaded deps preserve this?
Kenn On Tue, Jun 29, 2021 at 12:10 PM Luke Cwik <[email protected]> wrote: > I noticed that at some point in time we broke support for epoll (and unix > domain sockets) by not relocating and renaming the linux-x86_64 variant. > > I filed BEAM-12547[1] and was able to fix the shading to include the > correctly renamed epoll JNI library[2]. I was looking to perform a vendored > gRPC 1.36.0 release and follow-up by fixing our existing test to catch the > breakage by requiring ManagedChannelFactoryTest to run if the architecture > is Linux instead of when Epoll is available[3]. > > Any concerns on the release? > > 1: https://issues.apache.org/jira/browse/BEAM-12547 > 2: https://github.com/apache/beam/pull/15091 > 3: > https://github.com/apache/beam/blob/5fffad689e3fa7b6f788f3037a02fb215c1864ec/sdks/java/fn-execution/src/test/java/org/apache/beam/sdk/fn/channel/ManagedChannelFactoryTest.java#L48 >
