Looked at it. LGTM It looks portable enough to be useful for any future Go SDK based Expansion services.
I do wonder if there are more general names than "class" but that's a terminology quibble anyway. (Go doesn't use that term, as Go doesn't have inheritance based polymorphism.) Perhaps "type" is a good replacement, which is in use in most languages in one capacity or another? Certainly not a hard blocker. On Mon, Jul 26, 2021, 7:10 PM Chamikara Jayalath <chamik...@google.com> wrote: > Hi All, > > Currently, to define Java cross-language transforms, users have to define > three new Java classes: a Registrar, a Builder and a Config Object [1]. > > While this might not be too hard for a Java programmer, learning Java and > developing/building/releasing new classes just to use existing Java > transforms may be cumbersome for Python and Go users. To further simplify > the process for defining new Java cross-language transforms and usage of > such transforms from other SDKs I would like to propose an update to the > cross-language transform expansion protocol. > > Please see the following for details and let me know if you have any > comments. > > https://docs.google.com/document/d/1ECXSWicE31K-vSxdb4qL6UcmovOAWvE-ZHFT3NTM654/edit?usp=sharing > > Thanks, > Cham > > [1] > https://beam.apache.org/documentation/programming-guide/#create-x-lang-transforms >
