Thanks Danny! I did a first pass on comments, but do like the approach. Needs some justifications on why this path should be chosen over alternative implementations.
On Thu, Feb 24, 2022, 7:42 AM Danny McCormick <[email protected]> wrote: > Hey everyone, I put together a design doc for adding Bundle Finalization > in the Go Sdk and would appreciate any thoughts you have! > > Bundle finalization enables a DoFn to perform side effects after a runner > has acknowledged that it has durably persisted the output. Right now, Java > and Python support bundle finalization by allowing a user to register a > callback function which is invoked when the runner acknowledges that it has > persisted all output, but go does not have any such support. This proposes > an approach for adding bundle finalization in the Go Sdk by allowing users > to register callbacks during their normal DoFn execution. It generally > mirrors the behavior adopted by other languages and allows users to > dynamically specify their callbacks at runtime. > > Please share any feedback or support here: > https://docs.google.com/document/d/1dLylt36oFhsWfyBaqPayYXqYHCICNrSZ6jmr51eqZ4k/edit?usp=sharing > > Thanks, > Danny >
