I had this happen to me recently as well. After `git bisecting` led to confusing results, I ran my tests again via gradlew adding `--rerun-tasks` to the command. This is an expensive operation, but after I ran that I was able to test again with expected results. YMMV
Thanks, Evan On Tue, Jun 14, 2022 at 2:12 PM Niel Markwick <ni...@google.com> wrote: > I agree that it is very strange! > > I have also just repro'd it on the cleanest possible environment: a brand > new GCE debian 11 VM... > > sudo apt install git openjdk-11-jdk > git clone https://github.com/apache/beam.git > cd beam > git checkout b0d964c430 > ./gradlew :sdks:java:io:google-cloud-platform:test > > tests pass > > git checkout 4ffeae4d > ./gradlew :sdks:java:io:google-cloud-platform:test > > tests fail. > > > The test failure stack traces are pretty much identical - the only > difference being the test being run. > > They all complain about a Null PCollection from the directRunner (a couple > complain due to incorrect expected exceptions, or asserts in a finally > block, but they are failing because of the Null PCollection) > > I am not sure but I think the common ground _could_ be that a side input > is used in the failing tests. > > > org.apache.beam.sdk.Pipeline$PipelineExecutionException: > java.lang.NullPointerException: Null PCollection > at app//org.apache.beam.sdk.Pipeline.run(Pipeline.java:329) > at > app//org.apache.beam.sdk.testing.TestPipeline.run(TestPipeline.java:399) > at > app//org.apache.beam.sdk.testing.TestPipeline.run(TestPipeline.java:335) > at > app//org.apache.beam.sdk.io.gcp.spanner.SpannerIOWriteTest.deadlineExceededFailsAfterRetries(SpannerIOWriteTest.java:734) > at > java.base@11.0.13/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native > Method) > at > java.base@11.0.13/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base@11.0.13/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.base@11.0.13/java.lang.reflect.Method.invoke(Method.java:566) > at > app//org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) > at > app//org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > app//org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) > at > app//org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > at > app//org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) > at > app//org.apache.beam.sdk.testing.TestPipeline$1.evaluate(TestPipeline.java:323) > at > app//org.junit.rules.ExpectedException$ExpectedExceptionStatement.evaluate(ExpectedException.java:258) > at app//org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) > at > app//org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) > at app//org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) > at > app//org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) > at > app//org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) > at app//org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) > at app//org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) > at > app//org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) > at app//org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) > at app//org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) > at app//org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) > at app//org.junit.runners.ParentRunner.run(ParentRunner.java:413) > at > org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.runTestClass(JUnitTestClassExecutor.java:110) > at > org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:58) > at > org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:38) > at > org.gradle.api.internal.tasks.testing.junit.AbstractJUnitTestClassProcessor.processTestClass(AbstractJUnitTestClassProcessor.java:62) > at > org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51) > at > java.base@11.0.13/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native > Method) > at > java.base@11.0.13/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base@11.0.13/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.base@11.0.13/java.lang.reflect.Method.invoke(Method.java:566) > at > org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36) > at > org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24) > at > org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:33) > at > org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:94) > at com.sun.proxy.$Proxy2.processTestClass(Unknown Source) > at > org.gradle.api.internal.tasks.testing.worker.TestWorker$2.run(TestWorker.java:176) > at > org.gradle.api.internal.tasks.testing.worker.TestWorker.executeAndMaintainThreadName(TestWorker.java:129) > at > org.gradle.api.internal.tasks.testing.worker.TestWorker.execute(TestWorker.java:100) > at > org.gradle.api.internal.tasks.testing.worker.TestWorker.execute(TestWorker.java:60) > at > org.gradle.process.internal.worker.child.ActionExecutionWorker.execute(ActionExecutionWorker.java:56) > at > org.gradle.process.internal.worker.child.SystemApplicationClassLoaderWorker.call(SystemApplicationClassLoaderWorker.java:133) > at > org.gradle.process.internal.worker.child.SystemApplicationClassLoaderWorker.call(SystemApplicationClassLoaderWorker.java:71) > at > app//worker.org.gradle.process.internal.worker.GradleWorkerMain.run(GradleWorkerMain.java:69) > at > app//worker.org.gradle.process.internal.worker.GradleWorkerMain.main(GradleWorkerMain.java:74) > Caused by: java.lang.NullPointerException: Null PCollection > at > org.apache.beam.runners.direct.AutoValue_ImmutableListBundleFactory_CommittedImmutableListBundle.<init>(AutoValue_ImmutableListBundleFactory_CommittedImmutableListBundle.java:29) > at > org.apache.beam.runners.direct.ImmutableListBundleFactory$CommittedImmutableListBundle.create(ImmutableListBundleFactory.java:137) > at > org.apache.beam.runners.direct.ImmutableListBundleFactory$UncommittedImmutableListBundle.commit(ImmutableListBundleFactory.java:115) > at > org.apache.beam.runners.direct.BoundedReadEvaluatorFactory$InputProvider.getInitialInputs(BoundedReadEvaluatorFactory.java:224) > at > org.apache.beam.runners.direct.ReadEvaluatorFactory$InputProvider.getInitialInputs(ReadEvaluatorFactory.java:88) > at > org.apache.beam.runners.direct.RootProviderRegistry.getInitialInputs(RootProviderRegistry.java:80) > > > > > > > -- > <https://cloud.google.com> > * • **Niel Markwick* > * • *Cloud Solutions Architect <https://cloud.google.com/docs/tutorials> > * • *Google Belgium > * • *ni...@google.com > * • *+32 2 894 6771 > > > Google Belgium NV/SA, Steenweg op Etterbeek 180, 1040 Brussel, Belgie. RPR: > 0878.065.378 > > If you have received this communication by mistake, please don't forward > it to anyone else (it may contain confidential or privileged information), > please erase all copies of it, including all attachments, and please let > the sender know it went to the wrong person. Thanks > > > On Tue, 14 Jun 2022 at 19:17, Danny McCormick <dannymccorm...@google.com> > wrote: > >> Hey Niel, >> >> Unfortunately I can't repro on master, and I'm a little bit at a loss as >> to what could be causing this since the changes are all string changes >> (like you mentioned). I also don't see any Jenkins failures related to this >> (I *think* the Java PostCommits >> <https://ci-beam.apache.org/job/beam_PostCommit_Java/> should catch this >> generally). Any chance you could share some logs from your failing test >> run? I'm interested if there's a correlation between the failing tests >> (e.g. if they all call a specific function) or if there's additional info >> in the stacktrace. >> >> Thanks, >> Danny >> >> On Tue, Jun 14, 2022 at 12:16 PM Niel Markwick <ni...@google.com> wrote: >> >>> Developing on master/HEAD, I have a bunch of unit tests failing locally >>> due to Null PCollections >>> >>> java.lang.NullPointerException: Null PCollection >>> at >>> org.apache.beam.runners.direct.AutoValue_ImmutableListBundleFactory_CommittedImmutableListBundle.<init>(AutoValue_ImmutableListBundleFactory_CommittedImmutableListBundle.java:29) >>> >>> >>> eg for :sdks:java:io:google-cloud-platform:test, 271 failures out of >>> 1338 tests, all for this reason. >>> >>> These tests all pass locally when I checkout the 2.39 release tag, and >>> they don't fail in Jenkins-CI pre/post-commit tests either. >>> >>> Doing a git bisect gives the commit 4ffeae4d2b - Update all links to in >>> progress jiras to issues (#21749) >>> <https://github.com/apache/beam/commit/4ffeae4d2b800f2df36d2ea2eab549f2204d5691> >>> as >>> the one where the tests start to fail (They succeed in the parent >>> b0d964c4 >>> <https://github.com/apache/beam/commit/b0d964c43092994977b10272451acc24b4a62aad>), >>> however the only changes in that commit appear to be comments. >>> >>> I can reliably repro this - checking out 4ffeae4d2b, and running >>> :sdks:java:io:google-cloud-platform:test -- tests fail, checking >>> out b0d964c4 and they pass. >>> >>> Any hints on what could be going on here? >>> >>> >>> >>> >>> >>> >>> -- >>> <https://cloud.google.com> >>> * • **Niel Markwick* >>> * • *Cloud Solutions Architect >>> <https://cloud.google.com/docs/tutorials> >>> * • *Google Belgium >>> * • *ni...@google.com >>> * • *+32 2 894 6771 >>> >>> >>> Google Belgium NV/SA, Steenweg op Etterbeek 180, 1040 Brussel, Belgie. RPR: >>> 0878.065.378 >>> >>> If you have received this communication by mistake, please don't forward >>> it to anyone else (it may contain confidential or privileged information), >>> please erase all copies of it, including all attachments, and please let >>> the sender know it went to the wrong person. Thanks >>> >>
