> > Thank you Evan! How confident are you about the fix? > I validated the fix contained in #21895 <https://github.com/apache/beam/pull/21895> against a job running in Dataflow that previously failed immediately (with the exact issue described in #21690 <https://github.com/apache/beam/issues/21690>) when upgrading to 2.39.0 so that gives me good confidence that the issue is patched. I will say though that I don't have exceptional confidence in my own understanding of all Windowing implications (ex. `setWindowingStrategyInternal` Vs. `Window.into`), FWIW.
- Evan On Wed, Jun 15, 2022 at 1:46 PM Ahmet Altay <[email protected]> wrote: > > > On Wed, Jun 15, 2022 at 10:39 AM Evan Galpin <[email protected]> wrote: > >> RE https://github.com/apache/beam/issues/21690, I've just opened a PR >> with a fix: https://github.com/apache/beam/pull/21895. If that feels >> too rushed, I've also opened a PR to revert the change that introduced the >> regression in the first place: https://github.com/apache/beam/pull/21884 >> . >> >> For ElasticsearchIO to work at all in 2.40.0, one of >> https://github.com/apache/beam/pull/21895 or >> https://github.com/apache/beam/pull/21884 will need to be merged first. >> > > Thank you Evan! How confident are you about the fix? > > I will defer the decision to release manager ( @Pablo Estrada > <[email protected]>). > > >> >> Thanks, >> Evan >> >> >> On Tue, Jun 14, 2022 at 8:19 PM Ahmet Altay <[email protected]> wrote: >> >>> Thank you Kenn. >>> >>> To bring visibility, there are 2 blockers: >>> https://github.com/apache/beam/issues/21625 - assigned to Reuven >>> >> > @Reuven Lax <[email protected]> - ping on this one - Is this a release > blocker? > > >> https://github.com/apache/beam/issues/21690 - assigned to Evan >>> >>> Reuven, Evan, could you please comment on the open issues? Should they >>> be blocking the 2.40.0 release? >>> >>> Thank you! >>> Ahmet >>> >>> On Tue, Jun 14, 2022 at 7:35 AM Kenneth Knowles <[email protected]> wrote: >>> >>>> I did a pass this morning. I believe there is only one release blocker >>>> that doesn't already have a fix. If I closed your issue or moved it off the >>>> milestone, feel free to have a different opinion and revert my action. >>>> >>>> Kenn >>>> >>>> On Mon, Jun 13, 2022 at 5:04 PM Ahmet Altay <[email protected]> wrote: >>>> >>>>> >>>>> >>>>> On Tue, Jun 7, 2022 at 7:17 PM Ahmet Altay <[email protected]> wrote: >>>>> >>>>>> I apologize for digressing the release thread. To bring it back, >>>>>> please help Pablo with the release blockers ( >>>>>> https://github.com/apache/beam/milestone/2) :) >>>>>> >>>>> >>>>> @Pablo Estrada <[email protected]> - there are still 10 blockers on >>>>> that list. Could we move the non-critical items to the next release? Do >>>>> you >>>>> need any help? >>>>> >>>>> >>>>>> >>>>>> On Tue, Jun 7, 2022 at 6:47 PM Danny McCormick < >>>>>> [email protected]> wrote: >>>>>> >>>>>>> > A question related to priorities (P0, P1, etc.) as labels. Does it >>>>>>> mean that not all issues will have priority unless we explicitly set >>>>>>> these >>>>>>> labels? >>>>>>> >>>>>>> Technically yes, but this is a required field on all issue templates >>>>>>> (for example, our bug template >>>>>>> <https://github.com/apache/beam/issues/new?assignees=octocat&labels=bug%2Cawaiting+triage&template=bug.yml&title=%5BBug%5D%3A+>). >>>>>>> Our automation will automatically apply a label based on the response to >>>>>>> that field. >>>>>>> >>>>>> >>>>>> Nice. Thank you. >>>>>> >>>>>> >>>>>>> >>>>>>> On Tue, Jun 7, 2022 at 7:46 PM Ahmet Altay <[email protected]> wrote: >>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On Tue, Jun 7, 2022 at 10:19 AM Danny McCormick < >>>>>>>> [email protected]> wrote: >>>>>>>> >>>>>>>>> I'm good with that, that's consistent with the previous doc >>>>>>>>> behavior which pointed to the fix version page (e.g. >>>>>>>>> https://issues.apache.org/jira/projects/BEAM/versions/12351171). >>>>>>>>> I closed my pr since that approach is consistent with the current >>>>>>>>> state of >>>>>>>>> the docs, if we decide we just want the release manager to look at >>>>>>>>> P1s we >>>>>>>>> can reopen. >>>>>>>>> >>>>>>>> >>>>>>>> That makes sense. Release managers usually move most P0 and P1 >>>>>>>> issues out of the blockers lists for good reasons and the two lists >>>>>>>> tend to >>>>>>>> look very similar closer to the release. >>>>>>>> >>>>>>>> A question related to priorities (P0, P1, etc.) as labels. Does it >>>>>>>> mean that not all issues will have priority unless we explicitly set >>>>>>>> these >>>>>>>> labels? >>>>>>>> >>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Danny >>>>>>>>> >>>>>>>>> On Tue, Jun 7, 2022 at 12:30 PM Chamikara Jayalath < >>>>>>>>> [email protected]> wrote: >>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On Tue, Jun 7, 2022 at 7:33 AM Danny McCormick < >>>>>>>>>> [email protected]> wrote: >>>>>>>>>> >>>>>>>>>>> If we want to filter to P0/P1 issues, we can do that with this >>>>>>>>>>> query - https://github.com/apache/beam/issues?q=milestone:"2.40.0 >>>>>>>>>>> Release" label:P1,P0 is:open is:issue - I'll update the release >>>>>>>>>>> guide to point to that url instead of just the milestones page. PR >>>>>>>>>>> to do >>>>>>>>>>> this here - https://github.com/apache/beam/pull/21732 >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Nit: I think we'd want all open issues tagged for that release. >>>>>>>>>> Release manager can decide to bump P2s to the next release or raise >>>>>>>>>> the >>>>>>>>>> priority. >>>>>>>>>> >>>>>>>>>> Thanks, >>>>>>>>>> Cham >>>>>>>>>> >>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Thanks, >>>>>>>>>>> Danny >>>>>>>>>>> >>>>>>>>>>> On Mon, Jun 6, 2022 at 7:56 PM Ahmet Altay <[email protected]> >>>>>>>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>>> Is this (https://github.com/apache/beam/milestone/2) the link >>>>>>>>>>>> for 2.40.0 release blockers? If yes, are those 9 issues hard >>>>>>>>>>>> release >>>>>>>>>>>> blockers? (We used to limit release blockers to P1s and above, not >>>>>>>>>>>> sure >>>>>>>>>>>> what would be the right URL with the filter.) >>>>>>>>>>>> >>>>>>>>>>>> On Fri, Jun 3, 2022 at 10:41 AM Danny McCormick < >>>>>>>>>>>> [email protected]> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> The existing release blockers won't have their fix version >>>>>>>>>>>>> automatically migrated, I'll make sure to go through and make >>>>>>>>>>>>> sure those >>>>>>>>>>>>> get updated once the migration is done though. There are only 10 >>>>>>>>>>>>> of them >>>>>>>>>>>>> as of now, so it shouldn't be a big deal. >>>>>>>>>>>>> >>>>>>>>>>>>> Thanks, >>>>>>>>>>>>> Danny >>>>>>>>>>>>> >>>>>>>>>>>>> On Fri, Jun 3, 2022 at 1:38 PM Danny McCormick < >>>>>>>>>>>>> [email protected]> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>>> Yep! The release guide >>>>>>>>>>>>>> <https://beam.apache.org/contribute/release-guide/> and blocking >>>>>>>>>>>>>> bugs >>>>>>>>>>>>>> <https://beam.apache.org/contribute/release-blocking/#:~:text=Release%2Dblocking%20features,-By%20default%2C%20features&text=Beam%20has%20a%20steady%206,order%20to%20include%20the%20feature.> >>>>>>>>>>>>>> pages have been updated to reflect this flow. >>>>>>>>>>>>>> >>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>> Danny >>>>>>>>>>>>>> >>>>>>>>>>>>>> On Fri, Jun 3, 2022 at 1:31 PM Yichi Zhang <[email protected]> >>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>>> Thank you Pablo, should we now mark blocking issues with >>>>>>>>>>>>>>> github issues with milestones? >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> On Thu, Jun 2, 2022 at 8:36 AM Ahmet Altay <[email protected]> >>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Thank you Pablo! >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> On Wed, Jun 1, 2022 at 4:04 PM Pablo Estrada < >>>>>>>>>>>>>>>> [email protected]> wrote: >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Hi all, >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> The next (2.40.0) release branch cut is scheduled for >>>>>>>>>>>>>>>>> June 15th, according to >>>>>>>>>>>>>>>>> the release calendar [1]. >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> I would like to offer myself as tribute to do >>>>>>>>>>>>>>>>> this release. My plan is to cut the branch on that date, and >>>>>>>>>>>>>>>>> cherrypick release-blocking fixes afterwards, if any. >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Please help me make sure the release goes smoothly by: >>>>>>>>>>>>>>>>> - Making sure that any unresolved release blocking JIRA >>>>>>>>>>>>>>>>> issues for 2.40.0 should have their "Fix Version/s" marked as >>>>>>>>>>>>>>>>> " >>>>>>>>>>>>>>>>> 2.40.0" as soon as possible. >>>>>>>>>>>>>>>>> - Reviewing the current release blockers [2] and remove >>>>>>>>>>>>>>>>> the "Fix Version/s" if they don't meet the criteria at [3]. >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Let me know if you have any comments/objections/questions. >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>>>> -P. >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> [1] >>>>>>>>>>>>>>>>> https://calendar.google.com/calendar/embed?src=0p73sl034k80oob7seouanigd0%40group.calendar.google.com >>>>>>>>>>>>>>>>> [2] >>>>>>>>>>>>>>>>> https://issues.apache.org/jira/browse/BEAM-14539?filter=-1&jql=project%3DBEAM%20and%20fixVersion%3D2.40.0%20%20AND%20statusCategory%20!%3D%20Done%20order%20by%20updated%20DESC >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> [3] https://beam.apache.org/contribute/release-blocking/ >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>
