Fantastic document! I have a much stronger idea of how state and timers are supposed to work generally by reading it.
And the approach is very good, leveraging the new Go Generics in a reasonable way, without breaking the feel of the SDK. I can also see us adopting a similar technique more generally for SideInputs and Emitters, to help reduce the verbosity of the positional API the sdk has, though that is highly future looking of me. Maybe if we ever decide to do a V3. Thanks! On Thu, Jul 28, 2022, 1:17 PM Austin Bennett <whatwouldausti...@gmail.com> wrote: > Looks great! > > On Thu, Jul 28, 2022 at 10:54 AM Jack McCluskey via dev < > dev@beam.apache.org> wrote: > >> Great write-up on state and timers! The solution you chose feels very >> in-line with how the Go SDK works. Make sure the design doc makes it onto >> the wiki once you've addressed any feedback! >> >> On Thu, Jul 28, 2022 at 1:49 PM Kerry Donny-Clark via dev < >> dev@beam.apache.org> wrote: >> >>> I think this a perfect example of a clear design doc. Great, deeply >>> detailed alternatives considered and why they were rejected. This makes >>> review easy, and lets us follow your thought process. >>> I think this is a good implementation, and I support the chosen approach. >>> Kerry >>> >>> On Thu, Jul 28, 2022 at 1:41 PM Kenneth Knowles <k...@apache.org> wrote: >>> >>>> Really thorough. Love it! >>>> >>>> On Thu, Jul 28, 2022 at 9:02 AM Ritesh Ghorse via dev < >>>> dev@beam.apache.org> wrote: >>>> >>>>> Hey everyone, >>>>> >>>>> Danny <dannymccorm...@google.com> and I have been working on >>>>> designing the state and timers for Go SDK. We wrote a design doc with >>>>> user-facing API, execution details, and different alternatives considered. >>>>> It would be really helpful if we could get your >>>>> suggestions/feedback/comments on the design. >>>>> >>>>> Design Doc: >>>>> https://docs.google.com/document/d/1rcKa1Z6orDDFr1l8t6NA1eLl6zanQbYAEiAqk39NQUU/edit?usp=sharing >>>>> >>>>> Thanks! >>>>> Ritesh Ghorse >>>>> >>>>
