Thanks for the feedback. I will move forward with solution 1. On Mon, Sep 12, 2022 at 2:20 PM Danny McCormick <dannymccorm...@google.com> wrote:
> Thanks for writing this up Anand! I agree with you (and Andy) that > solution 1 is the best path forward. > > Thanks, > Danny > > On Mon, Sep 12, 2022 at 2:11 PM Andy Ye via dev <dev@beam.apache.org> > wrote: > >> Thanks Anand for the great summary! >> >> I'm leaning towards (solution 1) to allow users to pass in a custom >> namespace for full user control. If there needs to be a certain grouping or >> ordering of the metrics, the onus should be on the user to add an >> appropriate grouping prefix such as 'RunInference_' in front of all the >> custom namespaces. >> >> Best, >> Andy >> >> On Mon, Sep 12, 2022 at 1:31 PM Anand Inguva via dev <dev@beam.apache.org> >> wrote: >> >>> Hi all, >>> >>> I created a doc >>> <https://docs.google.com/document/d/1qf5APv1kw5nbVZIMgqEp1N4XYcb0cJP0KZc9PrUYCO4/edit?usp=sharing>[1] >>> to outline a few solutions on how to pass custom namespace to the >>> RunInference[2] transform for better tracking and usage of metrics. Please >>> go through it and let me know what you think. Any feedback would be >>> appreciated. >>> >>> Thanks, >>> Anand >>> >>> [1] >>> https://docs.google.com/document/d/1qf5APv1kw5nbVZIMgqEp1N4XYcb0cJP0KZc9PrUYCO4/edit?usp=sharing >>> >>> [2] >>> https://github.com/apache/beam/blob/2113ffcac3fa3d7522ceb22d03919e6edafe5e90/sdks/python/apache_beam/ml/inference/base.py#L269 >>> >>>
