(From someone who received education not in English and from another field). I first assumed this is some terminology just like "flaky", "smock test" because I came from another world and did not know most of the terms in this field. That said, I just assumed it was another term used in the field and just acknowledged that.
Just note that these "sickbayed" tests are not disabled from running. There are disabled test suites on https://ci-beam.apache.org/ having gray "🚫 " signs. Those tests are still running on schedule but we "expect" they fail / known to fail. If we really want to change. Maybe we could use "broken test", "unstable test" or something like that to make distinction to the disabled test suites we have. Best, Yi On Mon, Oct 17, 2022 at 3:26 PM Danny McCormick via dev <dev@beam.apache.org> wrote: > I'm +1 on this, sickbay was a new term for me when I joined the project. > One thing I will note: we still have plenty of sickbay references in our > code itself - https://github.com/apache/beam/search?p=1&q=sickbay - if we > decide to take this forward we should create an issue to remove those (with > the "good first issue" label). > > > By the way, is there any known reason not to have spaces in GitHub > Issues tags? > > Generally, no. GitHub gives you a label with spaces by default when you > create a new repo ("good first issue") and we already have multiple labels > with spaces ("awaiting triage", "good first issue", there are probably > more). > > I personally slightly prefer dashes because spaces make queries > <https://github.com/apache/beam/issues?q=is%3Aopen+is%3Aissue+label%3A%22awaiting+triage%22> > a little less clean since you need to quote the label (e.g. `is:open > is:issue *label:"disabled test"*` instead of is:open is:issue > *label:disabled-test*), but that is not a widely accepted standard. > > On Mon, Oct 17, 2022 at 3:10 PM Kenneth Knowles <k...@apache.org> wrote: > >> Hi all, >> >> I have gotten a lot of questions from people like "what is sickbay?" >> >> Because I am a Star Trek enthusiast I easily understood that if I >> "sickbay the test" means to disable it temporarily. And people on my team >> are used to this terminology. But this is not all people :-) and there are >> many name conflicts with products too. >> >> So I have edited the GitHub Issues tag "sickbay" to be "disabled test" >> and I suggest we use this term everywhere. >> >> By the way, is there any known reason not to have spaces in GitHub Issues >> tags? >> >> Kenn >> >
