Let's be careful about whether these tests are included in our presubmits. Contrib code with flaky tests has been a major pain point in the past.
On Sat, Sep 2, 2023 at 12:02 PM Austin Bennett <aus...@apache.org> wrote: > Wanting us to not miss this. @Mazlum TOSUN <mazlum.to...@gmail.com> is > happy to donate Asgarde to our project. > > It looks like he'd need a SGA and CCLA [ 1 ] on file; anything else? > > I recalled the donation of Euphoria [ 2 ] , so I looked at those threads [ > 3 ] for insights into the process. It didn't look like there was a needed > VOTE, so mostly a matter of ensuring necessary signatures, and ideally some > sort of consensus [ or non-opposition ] to the donation. > > > [ 1 ] https://www.apache.org/licenses/contributor-agreements.html > [ 2 ] https://beam.apache.org/documentation/sdks/java/euphoria/ > [ 3 ] https://lists.apache.org/thread/xzlx4rm2tvc36mmwvhyvtdvsw7bnjscp > > > > On Thu, Jun 15, 2023 at 7:05 AM Kerry Donny-Clark via dev < > dev@beam.apache.org> wrote: > >> This looks like an excellent contribution. I can easily understand the >> motivation, and I think Beam would benefit from a higher level abstraction >> for error handling. >> Kerry >> >> On Wed, Jun 14, 2023, 6:31 PM Austin Bennett <aus...@apache.org> wrote: >> >>> Hi Beam Devs, >>> >>> @Mazlum <https://www.linkedin.com/in/mazlum-tosun-900b1812/> was >>> suggested to consider donating Asgarde >>> <https://github.com/tosun-si/asgarde> to Beam for Java/Kotlin error >>> handling to Beam [ see: >>> https://2022.beamsummit.org/sessions/error-handling-asgarde/ for last >>> year's Beam Summit talk ], he is also the author of Pasgard >>> <https://github.com/tosun-si/pasgarde>e [ for Python ] and Milgard [ >>> for a simplified Kotlin API ]. >>> >>> Would Asgarde be a good contribution, something the Beam community would >>> be willing to accept? I imagine we might want it to live at >>> github.com/apache/beam-asgarde ? Or perhaps there is a good place in >>> github.com/apache/beam ?? >>> >>> Especially once/if officially part of Beam, I imagine we'd add follow-up >>> items like getting onto the website/docs, and related. >>> >>> Cheers, >>> Austin >>> >>> >>> P.S. This might warrant separate/additional conversations for his other >>> libraries, but let's focus any discussion on Asgarde for now? >>> >>