+1 (binding) We've done the validation we can for now, let's not hold up the release any longer.
(For those curious, there may be a brief period of time where Dataflow pipelines with 2.54 still default to Runner V1 in some regions as things roll out, but we expect this to be fully resolved next week.) On Fri, Feb 9, 2024 at 6:28 PM Robert Burke <lostl...@apache.org> wrote: > > I can agree to that Robert Bradshaw. Thank you for letting the community know. > > (Disclaimer: I am on the Dataflow team myself, but do try to keep my hats > separated when I'm release manager). > > It would be bad for Beam users who use Dataflow to try to use the release but > be unaware of the switch. I'm in favour of the path of least user issues, > wherever they're cropping up from. > > As a heads up, I'll likely not address this thread until Wednesday morning > (or if there's a sooner update) as a result of this request. > > Separately: > + 1 (binding) > I've done a few of the quickstarts from the validation sheets and updated my > own Beam Go code. Other than a non-blocking update to the Go wordcount > quickstart, I didn't run into any issues. > > Robert Burke > Beam 2.54.0 Release Manager > > On 2024/02/10 01:41:12 Robert Bradshaw via dev wrote: > > I validated that the release artifacts are all correct, tested some simple > > Python and Yaml pipelines. Everything is looking good so far. > > > > However, could I ask that you hold this vote open a little longer? We've > > got some Dataflow service side changes that relate to 2.54 being the first > > release where Runner v2 is the default for Java (big change on our side), > > and could use a bit of additional time to verify we have everything lined > > up correctly. We should be able to finish the validation early/mid next > > week at the latest. > > > > - Robert > > > > > > On Fri, Feb 9, 2024 at 2:57 PM Yi Hu via dev <dev@beam.apache.org> wrote: > > > > > Also tested with GCP IO performance benchmark [1]. Passed other than > > > SpannerIO where the benchmark failed due to issues in the test suite > > > itself > > > [2], not related to Beam. > > > > > > +1 but I had voted for another validation suite before for this RC > > > > > > [1] > > > https://github.com/GoogleCloudPlatform/DataflowTemplates/tree/main/it/google-cloud-platform > > > [2] https://github.com/GoogleCloudPlatform/DataflowTemplates/issues/1326 > > > > > > On Fri, Feb 9, 2024 at 9:43 AM Valentyn Tymofieiev via dev < > > > dev@beam.apache.org> wrote: > > > > > >> +1. > > >> > > >> Checked postcommit test results for Python SDK, and exercised a couple of > > >> Datadow scenarios. > > >> > > >> On Thu, Feb 8, 2024, 14:07 Svetak Sundhar via dev <dev@beam.apache.org> > > >> wrote: > > >> > > >>> +1 (Non-Binding) > > >>> > > >>> Tested with Python SDK on DirectRunner and Dataflow Runner > > >>> > > >>> > > >>> Svetak Sundhar > > >>> > > >>> Data Engineer > > >>> s <nellywil...@google.com>vetaksund...@google.com > > >>> > > >>> > > >>> > > >>> On Thu, Feb 8, 2024 at 12:45 PM Chamikara Jayalath via dev < > > >>> dev@beam.apache.org> wrote: > > >>> > > >>>> +1 (binding) > > >>>> > > >>>> Tried out Java/Python multi-lang jobs and upgrading BQ/Kafka transforms > > >>>> from 2.53.0 to 2.54.0 using the Transform Service. > > >>>> > > >>>> Thanks, > > >>>> Cham > > >>>> > > >>>> On Wed, Feb 7, 2024 at 5:52 PM XQ Hu via dev <dev@beam.apache.org> > > >>>> wrote: > > >>>> > > >>>>> +1 (non-binding) > > >>>>> > > >>>>> Validated with a simple RunInference Python pipeline: > > >>>>> https://github.com/google/dataflow-ml-starter/actions/runs/7821639833/job/21339032997 > > >>>>> > > >>>>> On Wed, Feb 7, 2024 at 7:10 PM Yi Hu via dev <dev@beam.apache.org> > > >>>>> wrote: > > >>>>> > > >>>>>> +1 (non-binding) > > >>>>>> > > >>>>>> Validated with Dataflow Template: > > >>>>>> https://github.com/GoogleCloudPlatform/DataflowTemplates/pull/1317 > > >>>>>> > > >>>>>> Regards, > > >>>>>> > > >>>>>> On Wed, Feb 7, 2024 at 11:18 AM Ritesh Ghorse via dev < > > >>>>>> dev@beam.apache.org> wrote: > > >>>>>> > > >>>>>>> +1 (non-binding) > > >>>>>>> > > >>>>>>> Ran a few batch and streaming examples for Python SDK on Dataflow > > >>>>>>> Runner > > >>>>>>> > > >>>>>>> Thanks! > > >>>>>>> > > >>>>>>> On Wed, Feb 7, 2024 at 4:08 AM Jan Lukavský <je...@seznam.cz> wrote: > > >>>>>>> > > >>>>>>>> +1 (binding) > > >>>>>>>> > > >>>>>>>> Validated Java SDK with Flink runner. > > >>>>>>>> > > >>>>>>>> Jan > > >>>>>>>> On 2/7/24 06:23, Robert Burke via dev wrote: > > >>>>>>>> > > >>>>>>>> Hi everyone, > > >>>>>>>> Please review and vote on the release candidate #2 for the version > > >>>>>>>> 2.54.0, > > >>>>>>>> as follows: > > >>>>>>>> [ ] +1, Approve the release > > >>>>>>>> [ ] -1, Do not approve the release (please provide specific > > >>>>>>>> comments) > > >>>>>>>> > > >>>>>>>> > > >>>>>>>> Reviewers are encouraged to test their own use cases with the > > >>>>>>>> release > > >>>>>>>> candidate, and vote +1 if > > >>>>>>>> no issues are found. Only PMC member votes will count towards the > > >>>>>>>> final > > >>>>>>>> vote, but votes from all > > >>>>>>>> community members is encouraged and helpful for finding > > >>>>>>>> regressions; you > > >>>>>>>> can either test your own > > >>>>>>>> use cases [13] or use cases from the validation sheet [10]. > > >>>>>>>> > > >>>>>>>> The complete staging area is available for your review, which > > >>>>>>>> includes: > > >>>>>>>> * GitHub Release notes [1], > > >>>>>>>> * the official Apache source release to be deployed to > > >>>>>>>> dist.apache.org [2], > > >>>>>>>> which is signed with the key with fingerprint D20316F712213422 [3], > > >>>>>>>> * all artifacts to be deployed to the Maven Central Repository [4], > > >>>>>>>> * source code tag "v2.54.0-RC2" [5], > > >>>>>>>> * website pull request listing the release [6], the blog post [6], > > >>>>>>>> and > > >>>>>>>> publishing the API reference manual [7]. > > >>>>>>>> * Python artifacts are deployed along with the source release to > > >>>>>>>> the > > >>>>>>>> dist.apache.org [2] and PyPI[8]. > > >>>>>>>> * Go artifacts and documentation are available at pkg.go.dev [9] > > >>>>>>>> * Validation sheet with a tab for 2.54.0 release to help with > > >>>>>>>> validation > > >>>>>>>> [10]. > > >>>>>>>> * Docker images published to Docker Hub [11]. > > >>>>>>>> * PR to run tests against release branch [12]. > > >>>>>>>> > > >>>>>>>> The vote will be open for at least 72 hours. It is adopted by > > >>>>>>>> majority > > >>>>>>>> approval, with at least 3 PMC affirmative votes. > > >>>>>>>> > > >>>>>>>> For guidelines on how to try the release in your projects, check > > >>>>>>>> out our RC > > >>>>>>>> testing guide [13]. > > >>>>>>>> > > >>>>>>>> Thanks, > > >>>>>>>> Robert Burke > > >>>>>>>> Beam 2.54.0 Release Manager > > >>>>>>>> > > >>>>>>>> [1] https://github.com/apache/beam/milestone/18?closed=1 > > >>>>>>>> [2] https://dist.apache.org/repos/dist/dev/beam/2.54.0/ > > >>>>>>>> [3] https://dist.apache.org/repos/dist/release/beam/KEYS > > >>>>>>>> [4] > > >>>>>>>> https://repository.apache.org/content/repositories/orgapachebeam-1368/ > > >>>>>>>> [5] https://github.com/apache/beam/tree/v2.54.0-RC2 > > >>>>>>>> [6] https://github.com/apache/beam/pull/30201 > > >>>>>>>> [7] https://github.com/apache/beam-site/pull/659 > > >>>>>>>> [8] https://pypi.org/project/apache-beam/2.54.0rc2/ > > >>>>>>>> [9] > > >>>>>>>> > > >>>>>>>> https://pkg.go.dev/github.com/apache/beam/sdks/v2@v2.54.0-RC2/go/pkg/beam > > >>>>>>>> [10] > > >>>>>>>> > > >>>>>>>> https://docs.google.com/spreadsheets/d/1qk-N5vjXvbcEk68GjbkSZTR8AGqyNUM-oLFo_ZXBpJw/edit#gid=28763708 > > >>>>>>>> [11] https://hub.docker.com/search?q=apache%2Fbeam&type=image > > >>>>>>>> [12] https://github.com/apache/beam/pull/30104 > > >>>>>>>> [13] > > >>>>>>>> > > >>>>>>>> https://github.com/apache/beam/blob/master/contributor-docs/rc-testing-guide.md > > >>>>>>>> > > >>>>>>>> > >
