https://github.com/apache/beam/pull/33935 is for Python. It reverts Lineage from using the new BoundedTrie metric type and keeps using the older StringSet type.
For Java we have not yet submitted this change on 2.63 hence no need to revert. https://github.com/apache/beam/pull/33891 is the PR against master will go in 2.64. https://github.com/apache/beam/pull/33921 Specificaly disable some tests in Java which uses the bounded trie metric (outside of Lineage) to test the metric type. Without this CP the test will continue to fail on release-2.63 branch. Thank you and sorry for the CPs. On Tue, Feb 11, 2025 at 8:50 AM Jack McCluskey via dev <dev@beam.apache.org> wrote: > The feature reversion (https://github.com/apache/beam/pull/33935) is > already in, do we also need to cherry-pick the PR disabling the tests? I > would think that all of the relevant tests would no longer exist on the > release branch after the feature PR was reverted > > On Tue, Feb 11, 2025 at 11:44 AM Rohit Sinha via dev <dev@beam.apache.org> > wrote: > >> https://github.com/apache/beam/pull/33921 is CP for release 2.63.0 >> This should be CPed so tests which emit newly introduced BoundedTrie are >> skipped on Dataflow runner as the service does not process this new metric >> type. >> >> Thank you. >> >> On Tue, Feb 11, 2025 at 8:30 AM Danny McCormick < >> dannymccorm...@google.com> wrote: >> >>> Here is the dev list RC voting thread >>> >>> ---------- Forwarded message --------- >>> From: Jack McCluskey via dev <dev@beam.apache.org> >>> Date: Tue, Feb 11, 2025 at 10:31 AM >>> Subject: Re: [VOTE] Release 2.63.0, release candidate #1 >>> To: <dev@beam.apache.org> >>> Cc: Jack McCluskey <jrmcclus...@google.com> >>> >>> >>> I've spun back up the test suites that were red, for the most part they >>> were Dataflow jobs that failed due to a combination of containers not being >>> released yet + the spin-up of so many test suites at once blowing past the >>> job quotas for the apache-beam-testing project. I don't expect any of them >>> to be true release blockers. >>> >>> https://github.com/apache/beam/pull/33935 reverts the feature on the >>> release branch while https://github.com/apache/beam/pull/33921 disables >>> the failing tests on master. That reversion probably necessitates an RC2 if >>> that feature breaks dataflow. >>> >>> On Mon, Feb 10, 2025 at 3:31 PM Yi Hu via dev <dev@beam.apache.org> >>> wrote: >>> >>>> checked https://github.com/apache/beam/pull/33870 reported a couple of >>>> test failures. Among that Java ValidatesRunner Dataflow might be release >>>> blocking. A fix is being prepared in >>>> https://github.com/apache/beam/pull/33921 >>>> >>>> Besides, would you mind commenting to >>>> https://github.com/apache/beam/pull/33870 suggesting each test >>>> failures reported there were release blocking or not? Rerun the specific >>>> tests if needed. >>>> >>>> Thanks, >>>> >>>> Yi >>>> >>>> On Fri, Feb 7, 2025 at 4:45 PM Danny McCormick via dev < >>>> dev@beam.apache.org> wrote: >>>> >>>>> +1 (binding) - I validated this with a few ML pipelines on the >>>>> interactive and Dataflow runners. >>>>> >>>>> Thanks, >>>>> Danny >>>>> >>>>> On Fri, Feb 7, 2025 at 4:00 PM XQ Hu via dev <dev@beam.apache.org> >>>>> wrote: >>>>> >>>>>> +1 (non-binding). Tested it with a simple Dataflow ML pipeline: >>>>>> https://github.com/google/dataflow-ml-starter/actions/runs/13205730673/job/36868592036 >>>>>> >>>>>> On Fri, Feb 7, 2025 at 11:46 AM Jack McCluskey via dev < >>>>>> dev@beam.apache.org> wrote: >>>>>> >>>>>>> Hi everyone, >>>>>>> >>>>>>> Please review and vote on the release candidate #1 for the version >>>>>>> 2.63.0, as follows: >>>>>>> [ ] +1, Approve the release >>>>>>> [ ] -1, Do not approve the release (please provide specific comments) >>>>>>> >>>>>>> Reviewers are encouraged to test their own use cases with the >>>>>>> release candidate, and vote +1 if no issues are found. Only PMC member >>>>>>> votes will count towards the final vote, but votes from all community >>>>>>> members are encouraged and helpful for finding regressions; you can >>>>>>> either >>>>>>> test your own use cases [13] or use cases from the validation sheet >>>>>>> [10]. >>>>>>> >>>>>>> The complete staging area is available for your review, which >>>>>>> includes: >>>>>>> * GitHub Release notes [1], >>>>>>> * the official Apache source release to be deployed to >>>>>>> dist.apache.org [2], which is signed with the key with fingerprint >>>>>>> FFFFFFFF (D20316F712213422 if automated) [3], >>>>>>> * all artifacts to be deployed to the Maven Central Repository [4], >>>>>>> * source code tag "v2.63.0-RC1" [5], >>>>>>> * website pull request listing the release [6], the blog post [6], >>>>>>> and publishing the API reference manual [7]. >>>>>>> * Python artifacts are deployed along with the source release to >>>>>>> dist.apache.org [2] and PyPI[8]. >>>>>>> * Go artifacts and documentation are available at pkg.go.dev [9] >>>>>>> * Validation sheet with a tab for 2.63.0 release to help with >>>>>>> validation [10]. >>>>>>> * Docker images published to Docker Hub [11]. >>>>>>> * PR to run tests against release branch [12]. >>>>>>> * Github Release pre-release page for v2.63.0-RC1 [13]. >>>>>>> >>>>>>> The vote will be open for at least 72 hours. Given that it is >>>>>>> Friday, I will not be including the weekend in the vote period. It is >>>>>>> adopted by majority approval, with at least 3 PMC affirmative votes. >>>>>>> >>>>>>> For guidelines on how to try the release in your projects, check out >>>>>>> our RC testing guide [13]. >>>>>>> >>>>>>> Thanks, >>>>>>> >>>>>>> Jack McCluskey >>>>>>> >>>>>>> [1] https://github.com/apache/beam/milestone/27 >>>>>>> [2] https://dist.apache.org/repos/dist/dev/beam/2.63.0/ >>>>>>> [3] https://dist.apache.org/repos/dist/release/beam/KEYS >>>>>>> [4] >>>>>>> https://repository.apache.org/content/repositories/orgapachebeam-1399/ >>>>>>> [5] https://github.com/apache/beam/tree/v2.63.0-RC1 >>>>>>> [6] https://github.com/apache/beam/pull/33905 >>>>>>> [7] https://github.com/apache/beam-site/pull/676 >>>>>>> [8] https://pypi.org/project/apache-beam/2.63.0rc1/ >>>>>>> [9] >>>>>>> https://pkg.go.dev/github.com/apache/beam/sdks/v2@v2.63.0-RC1/go/pkg/beam >>>>>>> [10] >>>>>>> https://docs.google.com/spreadsheets/d/1qk-N5vjXvbcEk68GjbkSZTR8AGqyNUM-oLFo_ZXBpJw/edit#gid=1785697132 >>>>>>> [11] https://hub.docker.com/search?q=apache%2Fbeam&type=image >>>>>>> [12] https://github.com/apache/beam/pull/33870 >>>>>>> [13] https://github.com/apache/beam/releases/tag/v2.63.0-RC1 >>>>>>> [14] >>>>>>> https://github.com/apache/beam/blob/master/contributor-docs/rc-testing-guide.md >>>>>>> >>>>>>> -- >>>>>>> >>>>>>> >>>>>>> Jack McCluskey >>>>>>> SWE - DataPLS PLAT/ Dataflow ML >>>>>>> RDU >>>>>>> jrmcclus...@google.com >>>>>>> >>>>>>> >>>>>>>
