> We generally do not block release on P2 bugs, and given that this regression already existed as early as Beam 2.65.0
I agree it is probably borderline. I voted -1 because I think this is pretty significant for Yaml pipelines (breaking timestamps + SQL is a somewhat basic use case), and the regression is fresh (last release) if not brand new, so I'd expect we'll still catch folks who do regular upgrades. The delay to RC2 (probably ready by Mondayish) seems worth the cost here to me, and building a new RC should be relatively low cost. > If we do have RC2, there is another Beam SQL DATETIME fix may be considered for cherry pick - https://github.com/apache/beam/pull/35743 +1 for including this, could you prep a cherry-pick? On Wed, Aug 6, 2025 at 2:33 PM Yi Hu via dev <dev@beam.apache.org> wrote: > We generally do not block release on P2 bugs, and given that this > regression already existed as early as Beam 2.65.0 > > If we do have RC2, there is another Beam SQL DATETIME fix may be > considered for cherry pick - https://github.com/apache/beam/pull/35743 > > On Wed, Aug 6, 2025 at 2:03 PM Vitalii Terentev <vteren...@apache.org> > wrote: > >> Thank you all! Based on the found issue, RC2 will be built soon, and sent >> out for vote shortly. This vote is now closed >> >> On 2025/08/01 07:01:32 Vitaly Terentyev via dev wrote: >> > Hi everyone, >> > Please review and vote on the release candidate #1 for the version >> 2.67.0, >> > as follows: >> > [ ] +1, Approve the release >> > [ ] -1, Do not approve the release (please provide specific comments) >> > >> > >> > Reviewers are encouraged to test their own use cases with the release >> > candidate, and vote +1 if >> > no issues are found. Only PMC member votes will count towards the final >> > vote, but votes from all >> > community members are encouraged and helpful for finding regressions; >> you >> > can either test your own >> > use cases [13] or use cases from the validation sheet [10]. >> > >> > The complete staging area is available for your review, which includes: >> > * GitHub Release notes [1], >> > * the official Apache source release to be deployed to dist.apache.org >> [2], >> > which is signed with the key with fingerprint D20316F712213422 as >> automated >> > [3], >> > * all artifacts to be deployed to the Maven Central Repository [4], >> > * source code tag "v2.67.0-RC1" [5], >> > * website pull request listing the release [6], the blog post [6], and >> > publishing the API reference manual [7]. >> > * Python artifacts are deployed along with the source release to >> > dist.apache.org [2] and PyPI[8]. >> > * Go artifacts and documentation are available at pkg.go.dev [9] >> > * Validation sheet with a tab for 2.67.0 release to help with validation >> > [10]. >> > * Docker images published to Docker Hub [11]. >> > * PR to run tests against release branch [12]. >> > * Github Release pre-release page for v2.67.0-RC1 [13]. >> > >> > The vote will be open for at least 72 hours. It is adopted by majority >> > approval, with at least 3 PMC affirmative votes. >> > >> > For guidelines on how to try the release in your projects, check out >> our RC >> > testing guide [13]. >> > >> > Thanks, >> > Release Manager >> > >> > [1] https://github.com/apache/beam/milestone/35 >> > [2] https://dist.apache.org/repos/dist/dev/beam/2.67.0/ >> > [3] https://dist.apache.org/repos/dist/release/beam/KEYS >> > [4] >> https://repository.apache.org/content/repositories/orgapachebeam-1409/ >> > [5] https://github.com/apache/beam/tree/v2.67.0-RC1 >> > [6] <https://github.com/apache/beam/pull/35359> >> https://github.com/apache/beam/pull/35759 >> > [7] https://github.com/apache/beam-site/pull/688 >> > [8] https://pypi.org/project/apache-beam/2.67.0rc1/ >> > [9] >> > >> https://pkg.go.dev/github.com/apache/beam/sdks/v2@v2.67.0-RC1/go/pkg/beam >> > [10] >> > < >> https://docs.google.com/spreadsheets/d/1qk-N5vjXvbcEk68GjbkSZTR8AGqyNUM-oLFo_ZXBpJw/edit?gid=629198601#gid=629198601 >> > >> https://docs.google.com/spreadsheets/d/1qk-N5vjXvbcEk68GjbkSZTR8AGqyNUM-oLFo_ZXBpJw/edit?gid=804148583#gid=804148583 >> > [11] https://hub.docker.com/search?q=apache%2Fbeam&type=image >> > [12] <https://github.com/apache/beam/pull/35271> >> https://github.com/apache/beam/pull/35667 >> > [13] https://github.com/apache/beam/releases/tag/v2.67.0-RC1 >> > [14] >> > >> https://github.com/apache/beam/blob/master/contributor-docs/rc-testing-guide.md >> > >> >
