On Tue, Apr 5, 2016 at 12:57 AM, Jason Kuster <[email protected]> wrote: > Hey JB, > > Just want to clarify - do you mean that beam_nightly would continue to run > on the schedule it currently has (SCM poll/hourly), plus one run at > midnight? > > I think Dan's question centers around whether beam_nightly build would just > run once every 24h. We want our postsubmit coverage to run more often than > that is my impression. Doing a deploy every time the SCM poll returns some > changes seems like an aggressive schedule to me, but I welcome your > thoughts there. Otherwise we could keep beam_mavenverify running on the scm > poll/hourly schedule and add the beam_nightly target which just does a > single deploy every 24h.
Unless it's too expensive, I would suggest we do a mvn verify every time the branch changes (plus at some regular interval). The nightly target would deploy just at midnight (and I don't see much value, actually it's probably counter-productive, to deploy more often than that). > On Tue, Apr 5, 2016 at 12:41 AM, Jean-Baptiste Onofré <[email protected]> > wrote: > >> Hi Dan, >> >> you can have both mvn clean deploy and mvn clean verify, but IMHO, the >> first already covers the second ;) >> >> So, I think mvn clean deploy is fine instead of clean verify. >> >> WDYT ? >> >> Regards >> JB >> >> >> On 04/05/2016 08:05 AM, Dan Halperin wrote: >> >>> I am completely behind producing nightly jars. >>> >>> But, I don't think that `beam_MavenVerify` is completely redundant -- I >>> was >>> under the impression it was our main post-submit coverage. Is that wrong? >>> >>> If I'm not wrong, then I think this should simply be a fourth Jira target >>> that runs every 24h. >>> >>> On Mon, Apr 4, 2016 at 10:50 PM, Jean-Baptiste Onofré <[email protected]> >>> wrote: >>> >>> Hi beamers, >>>> >>>> Now, on Jenkins, we have three jobs: >>>> >>>> - beam_PreCommit does a mvn clean verify for each opened PR >>>> - beam_MavenVerify does a mvn clean verify on master branch >>>> - beam_RunnableOnService_GoogleCloudDataflow does a mvn clean verify >>>> -PDataflowPipelineTests on master branch >>>> >>>> As discussed last week, Davor and I are working on renaming (especially >>>> package). >>>> >>>> Once this renaming done (it should take a week or so), I propose to >>>> change >>>> beam_MavenVerify as beam_Nightly: it will do a mvn clean deploy deploying >>>> SNAPSHOTs on the Apache SNAPSHOT repo (deploy phase includes verify and >>>> test of course) with a schedule every night and SCM change. >>>> >>>> It will allow people to test and try beam without building. >>>> >>>> Thoughts ? >>>> >>>> Regards >>>> JB >>>> -- >>>> Jean-Baptiste Onofré >>>> [email protected] >>>> http://blog.nanthrax.net >>>> Talend - http://www.talend.com >>>> >>>> >>> >> -- >> Jean-Baptiste Onofré >> [email protected] >> http://blog.nanthrax.net >> Talend - http://www.talend.com >> > > > > -- > ------- > Jason Kuster > Apache Beam (Incubating) / Google Cloud Dataflow
