For the BEAM-12345 tag, we have only really been doing that for PR titles, not commits, right? Then as long as you can read the real title on https://github.com/apache/incubator-beam/pulls I'm happy, and for my screen layout I think as many as 150 chars would be fine. I will experiment with tagging components in the PR title when it seems appropriate.
On Thu, May 12, 2016 at 2:52 AM, Maximilian Michels <[email protected]> wrote: > @Aljoscha: Yes, less space for the commit message if it has to fit > into 70 chars. I'm not sure how important a 70 character limit is > nowadays. > > @Davor I think your observation is correct. In Flink we also like to > do tagged commits but enforcing it is almost impossible. Automatic > tagging would be super cool. > > On Wed, May 11, 2016 at 4:11 PM, Davor Bonaci <[email protected]> > wrote: > > In general, I think this is fine to try, but I think its reliability will > > likely end up being low. There's a human factor involved -- people will > > forget, pull request will evolve in unexpected ways -- all leading to a > low > > reliability of this indicator. > > > > I think it would be really awesome to have automatic tagging. Not really > on > > the priority list right now, but I'm hopeful we'll have something like > that > > in the not-so-distant future. > > > > On Wed, May 11, 2016 at 3:00 AM, Aljoscha Krettek <[email protected]> > > wrote: > > > >> This will, however, also take precious space in the Commit Title. And > some > >> commits might not be about only one clear-cut component. > >> > >> On Wed, 11 May 2016 at 11:43 Maximilian Michels <[email protected]> wrote: > >> > >> > +1 I think it makes it easier to see at a glance to which part of Beam > >> > a commit belongs. We could use the Jira components as tags. > >> > > >> > On Wed, May 11, 2016 at 11:09 AM, Jean-Baptiste Onofré < > [email protected]> > >> > wrote: > >> > > Hi Manu, > >> > > > >> > > good idea. Theoretically the component in the corresponding Jira > should > >> > give > >> > > the information, but for convenience, we could add a "tag" in the > >> commit > >> > > comment. > >> > > > >> > > Regards > >> > > JB > >> > > > >> > > > >> > > On 05/10/2016 06:27 AM, Manu Zhang wrote: > >> > >> > >> > >> Guys, > >> > >> > >> > >> As I've been developing Gearpump runner for Beam, I've closely > watched > >> > the > >> > >> pull requests updates for API changes. Sometimes, it turns out > changes > >> > are > >> > >> only to be applied to a specific runner after I go through the > codes. > >> > >> Could > >> > >> we add a tag in the pull request title / commit comment to mark > >> whether > >> > >> it's API change or Runner specific change, or something else, like, > >> > >> [BEAM-XXX] [Direct-Java] Comments... ? > >> > >> > >> > >> Thanks, > >> > >> Manu Zhang > >> > >> > >> > > > >> > > -- > >> > > Jean-Baptiste Onofré > >> > > [email protected] > >> > > http://blog.nanthrax.net > >> > > Talend - http://www.talend.com > >> > > >> >
