Ah I forgot this: we should also think about specifying the capabilities for Streaming/Batch execution separately. AFAIK, the Flink and Spark runners have completely separate code paths for translation depending on that mode switch and also different capabilities in the two modes.
On Sat, 11 Jun 2016 at 07:48 Aljoscha Krettek <[email protected]> wrote: > Hi, > this looks very good! One thing I noticed is that there is no WriteToSink. > Right now, there are no tests in the RunnableOnService category that test > the Sink API but we might be able to add some. (Sinks are implemented as a > couple of DoFns, so it's not strictly necessary but it might still be good > to verify the output of these sinks.) > > Best, > Aljoscha > > On Sat, 11 Jun 2016 at 01:34 Thomas Groh <[email protected]> wrote: > >> Hey Beamers! >> >> We have a lovely Capability Matrix ( >> http://beam.incubator.apache.org/capability-matrix/) which describes what >> runners can do, and what's in the model. However, right now we only have >> one way to specify that a test is useful to be executed in a runner, the >> RunnableOnService category. >> >> I've worked on a document to expand the number of annotations to be more >> in >> line with the capability matrix, which should help runner writers test >> more >> precisely with regards to the Beam model. The document is located at >> >> https://docs.google.com/document/d/1fICxq32t9yWn9qXhmT07xpclHeHX2VlUyVtpi2WzzGM/edit?usp=sharing >> , >> and I've added edit access for all of our committers. >> >> Feel free to take a look and leave any comments you may have, >> >> Thanks, >> >> Thomas >> >
