Hi Manu, Any time you want to merge master into your branch just send a PR -- any of us will be happy to review and merge but especially Kenn and I.
(Python-sdk has been doing the same.) Dan On Tue, Jul 26, 2016 at 10:13 PM, Manu Zhang <[email protected]> wrote: > Hi JB, > > Thanks. If my PR is based on master but against gearpump-runner branch, it > will contain other changes on master. Right ? > > On Wed, Jul 27, 2016 at 12:58 PM Jean-Baptiste Onofré <[email protected]> > wrote: > > > > > > > Hi Manu > > I would suggest to prepare a PR based on master. I would be more than > > happy to help you on this. > > Regards JB > > > > -------- Original message -------- > > From: Manu Zhang <[email protected]> > > Date: 27/07/2016 04:32 (GMT+01:00) > > To: [email protected] > > Subject: how to work on gearpump-runner branch > > > > Hi All, > > > > As gearpump-runner has been merged into > > https://github.com/apache/incubator-beam/tree/gearpump-runner branch, > I'd > > like to add ask about our working model here. > > > > 1. how (often) should be the branch synced with master and who will > commit > > it ? > > 2. Do I work on new PRs based on branch or master ? > > > > For example, I need to move `RunnableOnService` tests into a profile > > following [BEAM-479] Execute RunnableOnService tests only when runner > > options provided <https://github.com/apache/incubator-beam/pull/709> > > which hasn't made into gearpump-runner branch. Also, the changes conflict > > with the branch. What should I do in this case ? > > > > Any references or documentations would be helpful as well. > > > > Thanks, > > Manu Zhang > > <https://github.com/apache/incubator-beam/tree/gearpump-runner> > > >
