+Kenn I believe this is done because if there is no output, no assertions will be run and tests will fail silently. (This was a side effect of switching from side inputs to groupbykey for this flow, which enabled testing of triggers/panes/etc.)
On Wed, Nov 2, 2016 at 5:19 AM, Amit Sela <[email protected]> wrote: > I've proposed https://github.com/apache/incubator-beam/pull/1257 (also > opened a ticket). > Tested locally Direct/Flink/Spark runners, and it looks fine, I've issued a > PR to see if it affects Dataflow runner. > > Amit. > > On Wed, Nov 2, 2016 at 11:56 AM Jean-Baptiste Onofré <[email protected]> > wrote: > > > Agree, this element should be removed. > > > > Regards > > JB > > > > On 11/02/2016 10:53 AM, Amit Sela wrote: > > > Hi all, > > > > > > I've been looking at PAssert and I've notice that > PAssert.GroupedGlobally > > > points > > > < > > https://github.com/apache/incubator-beam/blob/master/ > sdks/java/core/src/main/java/org/apache/beam/sdk/testing/PAssert.java#L825 > > > > > > that it will result in a singe empty iterable even if the input > > PCollection > > > is empty. > > > This is a weird behaviour as it may cause following assertions to fail. > > > > > > Wouldn't it be more correct to remove (filter out ?) this element ? > > > > > > Thanks, > > > Amit > > > > > > > -- > > Jean-Baptiste Onofré > > [email protected] > > http://blog.nanthrax.net > > Talend - http://www.talend.com > > >
