That's the plan, I will cancel the RC#1 vote and start a RC#2.
Regards
JB
On 12/15/2016 09:27 PM, Dan Halperin wrote:
I think JB and Davor are right, have heard other supporting votes, and I
haven't heard any specific disagreement.
My understanding of rules/procedure is that JB as release manager is free
to cancel the vote right now and begin RC2 when he is ready.
On Thu, Dec 15, 2016 at 11:36 AM, Jean-Baptiste Onofré <j...@nanthrax.net>
wrote:
-1 (binding)
I would include the fix for metrics and impacting dataflow and flink
runners.
I agree with Davor: I would prefer to cut a RC2.
Regards
JB
On Dec 15, 2016, 20:06, at 20:06, Kenneth Knowles <k...@google.com.INVALID>
wrote:
Agreed. I had though the issue in PR #1620 only affected Dataflow (in
which
case we could address it in the service) but it now also affects the
Flink
runner, so it should be included in the release.
On Thu, Dec 15, 2016 at 10:46 AM, Eugene Kirpichov <
kirpic...@google.com.invalid> wrote:
There is one more data-loss type error, a fix for which should go
into the
release.
https://github.com/apache/incubator-beam/pull/1620
On Thu, Dec 15, 2016 at 10:42 AM Davor Bonaci <da...@apache.org>
wrote:
I think we should build another RC.
Two issues:
* Metrics issue that JB pointed out earlier. It seems to cause a
somewhat
poor user experience for every pipeline executed on the Direct
runner.
(Thanks JB for finding this out!)
* Failure of testSideInputsWithMultipleWindows in Jenkins [1].
Both issues seem easy, trivial, non-risky fixes that are already
committed
to master. I'd suggest just taking them.
Davor
[1]
https://builds.apache.org/view/Beam/job/beam_PostCommit_
Java_RunnableOnService_Dataflow/1819/
On Thu, Dec 15, 2016 at 8:45 AM, Ismaël Mejía <ieme...@gmail.com>
wrote:
+1 (non-binding)
- verified signatures + checksums
- run mvn clean verify -Prelease, all artifacts+tests run
smoothly
The release artifacts are signed with the key with fingerprint
8F0D334F
https://dist.apache.org/repos/dist/release/incubator/beam/KEYS
I just created a JIRA to add the signer/KEYS information in the
release
template, I will do a PR for this later on.
Ismaël
On Thu, Dec 15, 2016 at 2:26 PM, Jean-Baptiste Onofré
<j...@nanthrax.net
wrote:
Hi Amit,
thanks for the update.
As you changed the Jira, the Release Notes are now up to date.
Regards
JB
On 12/15/2016 02:20 PM, Amit Sela wrote:
I see three problems in the release notes (related to Spark
runner):
Improvement:
....
[BEAM-757] - The SparkRunner should utilize the SDK's
DoFnRunner
instead
of
writing it's own.
....
[BEAM-807] - [SparkRunner] Replace OldDoFn with DoFn
....
[BEAM-855] - Remove the need for --streaming option in the
spark
runner
BEAM-855 is duplicate and probably shouldn't have had a Fix
Version.
The other two are not a part of this release - I was probably
too
eager
to
mark them fixed after merge and I accidentally put 0.4.0 as
the Fix
Version.
I made the changes in JIRA now.
Thanks,
Amit
On Thu, Dec 15, 2016 at 3:09 PM Jean-Baptiste Onofré <
j...@nanthrax.net
wrote:
Reviewing and testing the release, I see:
16/12/15 14:04:47 ERROR MetricsContainer: Unable to update
metrics
on
the current thread. Most likely caused by using metrics
outside the
managed work-execution thread.
It doesn't block the execution of the pipeline, but
basically, it
means
that metrics don't work anymore.
I'm investigating.
Regards
JB
On 12/15/2016 01:46 PM, Jean-Baptiste Onofré wrote:
Hi everyone,
Please review and vote on the release candidate #1 for the
version
0.4.0-incubating, as follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific
comments)
The complete staging area is available for your review,
which
includes:
* JIRA release notes [1],
* the official Apache source release to be deployed to
dist.apache.org
[2],
* all artifacts to be deployed to the Maven Central
Repository
[3],
* source code tag "v0.4.0-incubating-RC1" [4],
* website pull request listing the release and publishing
the API
reference
manual [5].
The vote will be open for at least 72 hours. It is adopted
by
majority
approval, with at least 3 PPMC affirmative votes.
Thanks,
Regards
JB
[1]
https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
ctId=12319527&version=12338590
[2]
https://dist.apache.org/repos/dist/dev/incubator/beam/0.4.0-
incubating/
[3]
https://repository.apache.org/content/repositories/orgapachebeam-1006/
[4]
https://git-wip-us.apache.org/repos/asf?p=incubator-beam.git
;a=tag;h=85d1c8a2f85bbc667c90f55ff0eb27de5c2446a6
[5] https://github.com/apache/incubator-beam-site/pull/109
--
Jean-Baptiste Onofré
jbono...@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
--
Jean-Baptiste Onofré
jbono...@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
--
Jean-Baptiste Onofré
jbono...@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
