Eddie All these HOWTOs are in the code. I will put them into a readme file.
See my comments inline for your proposal. -----Original Message----- From: Eddie O'Neil [mailto:[EMAIL PROTECTED] Sent: Tuesday, August 30, 2005 9:33 PM To: Beehive Developers Subject: Re: Beehive Compiler Test Julie-- This looks good; thanks for working up the additional tests. I've added a couple of comments below that are probably worth addressing before someone commits the patch. Also, is there a doc / HOWTO about how to enable / disable / add tests to the compiler's test suite? Seems that the checkin should include that information. :) Will be great to get these into the tree. Eddie ::::: 1) the netui/test/ant/netui-test-imports.xml file uses an explicit <pathconvert> to set the compiler-tests.classpath. Does this really need to happen? Can't we just let Ant do the conversion for us depending on the OS via something like: <property name="classpath" refid="compiler-tests-dependency.path"/> which (I think) would create a ${classpath} variable with the correct path separator? [JZ] Tried that it does not work. Have to convert it. When I put it into the system property and specify it as a path instead of value, ant will convert the ";" into what ever the local system separator. That is why it is now working on Linux with no problem. 2) the netui/test/ant/build.xml file has two lines like: <delete dir="${drt.testResults.dir}}"/> <delete dir="${bvt.testResults.dir}}"/> which just need to be fixed to: <delete dir="${drt.testResults.dir}"/> <delete dir="${bvt.testResults.dir}"/> before someone commits this. [JZ] I will clean up the typo there 3) the PageFlowCompilerTest class has a bunch of "protected File" members that don't seem to be used for various JARs like Velocity, Servlet, Controls, etc. Would be good practice to remove these. [JZ} I will check and do some cleanups as needed 4) TestPropertyMgr has a lot of public static variables that aren't used outside of that class. Might be worth making them private so that unnecessary dependencies aren't taken on them. [JZ] I will check and make they are what they need to be 5) Beehive uses commons-logging for debugging; right now, the compiler tests seem to use System.err. Might be worth switching them over to using Log instances. [JZ] Good idea to do this. I can submit a patch later if we want this in sooner, other wise I will do them all together. On 8/30/05, Julie Zhuo <[EMAIL PROTECTED]> wrote: > Thanks Rich for your time and effort! Let me know if you see anything > that needs to be improved. > > Julie > > -----Original Message----- > From: Rich Feit [mailto:[EMAIL PROTECTED] > Sent: Tuesday, August 30, 2005 3:22 PM > To: Beehive Developers > Subject: Re: Beehive Compiler Test > > Hi Julie, > > Thank you for this -- it will be *great* to have compiler tests in the > tree. It's been a gaping hole in our otherwise-comprehensive test > suite. I will take a look at this and try to get it in as soon as > possible. > > Thanks again, > Rich > > Julie Zhuo wrote: > > > I have just attached a patch to > > http://issues.apache.org/jira/browse/BEEHIVE-902. It > > > > > > > > It compiles each page flow as a junit test. It redirects any warning > > or error output to the warningsorerrors.actual file and then compare > > with the expected one that is recorded in the expectedOutput > > directory. It also conducts a line comparison between the generated > > struts config file and the expected ones that are recorded in the > > expectedOutput directory. Any mismatch will produce a test failure. > > > > > > > > There are 70 active pageflow compiler tests included in this patch. > > The directory names in the test suite dir hopefully are self > > explanatory and there are also some comments in each individual test > too. > > > > > > > > If you have any comments or recommendations, please feel free to let > > me know. Thanks for your attention. > > > > > > > > Julie > > > > > > > > > > > > *Julie Zhuo* > > Software Engineer QA > > > > Phone: 303.998.2078 > > [EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]> > > > > > > > > > > > > > > > > *BEA Systems, Inc.* > > 4001 Discovery Drive > > > > Suite 340 > > Boulder, CO 80303 > > > > www.bea.com <http://www.bea.com> > > > > > > > > > > > > > > > >
