Thanks for digging into this, Krista.  Our recent move off of XMLBeans
exposed an existing bug in the merging of @Jpf.MessageBundle annotations
where there is no bundleName attribute specified.  This means that you
cannot extend a page flow and override its default message bundle.  I
personally don't think this needs to block v1, but I have a local fix
for it ready to go -- will attach the changes momentarily. 

Any comments on whether this should be a V1-blocker?

Thanks,
Rich

Krista Baker (JIRA) wrote:

>some message bundles not appearing in generated struts-config files
>-------------------------------------------------------------------
>
>         Key: BEEHIVE-950
>         URL: http://issues.apache.org/jira/browse/BEEHIVE-950
>     Project: Beehive
>        Type: Bug
>  Components: NetUI  
>    Versions: V1    
>    Reporter: Krista Baker
> Assigned to: Rich Feit 
>     Fix For: V1
>
>
>After the change to remove xml beans from the distribution, certain message 
>bundle attributes declared in the controllers are not showing up in the 
>generated struts-config files and are not being displayed as expected.
>
>Controller snippet:
>@Jpf.Controller(
>    messageBundles = {
>        @Jpf.MessageBundle(bundleName = "myBundle",bundlePath = 
> "properties.NewMessages")
>})
>public class MessageResourceController extends 
>parent.messageResource.MessageResourceController
>{}
>
>Prior to the xml bean change the following section was generated in the struts 
>config:
><message-resources key="_defaultMsgs" 
>parameter="org.apache.beehive.netui.pageflow.validation.defaultMessages" 
>null="true"/>
><message-resources key="myBundle" parameter="properties.Messages" null="true"/>
><message-resources key="myBundle" parameter="properties.NewMessages" 
>null="true"/>
>
>After the removal of xml beans the following section is generated in the 
>struts config:
><message-resources key="_defaultMsgs" null="true" 
>parameter="org.apache.beehive.netui.pageflow.validation.defaultMessages"/>
><message-resources key="myBundle" null="true" parameter="properties.Messages"/>
>
>Notice that the NewMessages messageBundle declared in the controller snippet 
>is no longer generated.  This changes the output messages that should be 
>overridden to the ones in the defaultMsgs bundle and causes some tag errors 
>because it cannot find the message requested in the message bundles listed in 
>the config.
>
>  
>

Reply via email to