[ http://issues.apache.org/jira/browse/BEEHIVE-863?page=all ]
Rich Feit updated BEEHIVE-863:
------------------------------
Assign To: Carlin Rogers (was: Rich Feit)
Hey Carlin, I've got a few comments/questions before submitting this patch...
ConfigurePopup.java:
---
- This block:
-> * @jsptagref.databindable false
-> * @jsptagref.attributesyntaxvalue <i>string_popupFunc</i>
should change to this:
-> * @jsptagref.databindable true
-> * @jsptagref.attributesyntaxvalue <i>boolean_passFormFields</i>
- What would you think of changing "passFormFields" to "updateFormFields"?
- getNearestForm(): could you pass this along to Daryl to get his review on
that? I feel like there might be subtleties that we need to watch out for (but
I could be making this up :) ).
PopupSupport.java:
---
It looks like the regular popup function and the function that pops up WITH a
form could be combined into one function, with the form passed as the
(optional) last argument. I think this would be cleaner -- what do you think?
> Passing a FormBean to a popup
> -----------------------------
>
> Key: BEEHIVE-863
> URL: http://issues.apache.org/jira/browse/BEEHIVE-863
> Project: Beehive
> Type: Improvement
> Components: NetUI
> Reporter: Jack Rudnick
> Assignee: Carlin Rogers
> Priority: Critical
> Attachments: j863-first-patch.txt, j863-patch2.txt
>
> A popup is currently reached via a nested action, however, you can't pass a
> FormBean (and more importantly, its values) from a parent action to the
> nested action for use in the popup. An example of how you may want to use
> this would be:
> > 1) parent form/page has a "To" text field in a form.
> > 2) I type in "[EMAIL PROTECTED]"
> > 3) click the button (netui:button popup=true) to trigger the
> popup in the parent page
> > 4) popup has its own form/page that has a "To" text field.
> > 5) When the popup renders, the popups "To" field should be
> prepopulated with the "hello [EMAIL PROTECTED]" value.
> You can currently pass the values of a popup to the parent, thus you should
> be able to go the other way (pass the parent values to the popup) with a
> given framework way other than constructing some javascript to do this in a
> custom manner. One reason why this probably doesn't currently work, is when
> you click the netui:button it doesn't submit the parent form, thus the form
> and values don't get persisted for use by the popup.
> This is currently a very limiting shortcoming of using popups.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
