[ 
http://issues.apache.org/jira/browse/BEEHIVE-863?page=comments#action_12330608 
] 

Carlin Rogers commented on BEEHIVE-863:
---------------------------------------

Rich, thanks for giving this patch a review. Yes, I'll make the suggested name 
change in ConfigurePopup.java and fix the bogus copy/paste javadoc comment. 

In PopupSupport.java, I had the new function that pops up with a form separate 
because we already had the popup window as a last argument so that it could be 
optional to anyone who had created their own popupFunc. In V1, there are only 
four arguments (url, name, features, replace) but with the fix to BEEHIVE-542, 
we added the name of the popup window. I think you're right, that another 
optional argument in this case should not be an issue, but I was worried that 
it wasn't obvious to users. I'll add this change, along with the others and 
create a new patch.

> Passing a FormBean to a popup
> -----------------------------
>
>          Key: BEEHIVE-863
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-863
>      Project: Beehive
>         Type: Improvement
>   Components: NetUI
>     Reporter: Jack Rudnick
>     Assignee: Carlin Rogers
>     Priority: Critical
>  Attachments: j863-first-patch.txt, j863-patch2.txt
>
> A popup is currently reached via a nested action, however, you can't pass a 
> FormBean (and more importantly, its values) from a parent action to the 
> nested action for use in the popup.  An example of how you may want to use 
> this would be:
>       >       1) parent form/page has a "To" text field in a form.
>       >       2) I type in "[EMAIL PROTECTED]"
>       >       3) click the button (netui:button popup=true) to trigger the 
> popup in the parent page
>       >       4) popup has its own form/page that has a "To" text field.
>       >       5) When the popup renders, the popups "To" field should be 
> prepopulated with the "hello [EMAIL PROTECTED]" value.
> You can currently pass the values of a popup to the parent, thus you should 
> be able to go the other way (pass the parent values to the popup) with a 
> given framework way other than constructing some javascript to do this in a 
> custom manner.  One reason why this probably doesn't currently work, is when 
> you click the netui:button it doesn't submit the parent form, thus the form 
> and values don't get persisted for use by the popup.
> This is currently a very limiting shortcoming of using popups.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to