Carlin-- I've been looking at this fix and at the test and am curious about a couple of things. First, why is this an interesting thing to do -- ie, what's the use case? If a controller is created outside of the runtime, isn't there a contract that says that the flow controller will be driven through its entire lifecycle?
The problem is that simply by creating the page flow, controls will be initialized, but without driving the controller through its lifecycle, they're never torn down. So, what's the contract between the caller and the JPF instance here? I've not tried this specific case, but if the control being used from the test accessed a DB, it would leak ResultSets in this case. Similar things could be true for other control types. Also, can we expand the test to ensure that the right thing happens to the control bean context when the JPF *is* driven through its lifecycle? Thanks... Eddie ---------- Forwarded message ---------- From: [EMAIL PROTECTED] <[EMAIL PROTECTED]> Date: Nov 11, 2005 12:37 AM Subject: svn commit: r332482 - in /beehive/trunk/netui: src/pageflow/org/apache/beehive/netui/pageflow/internal/ test/webapps/drt/coreWeb/WEB-INF/ test/webapps/drt/coreWeb/miniTests/createPageFlow/ test/webapps/drt/src/miniTests/createPageFlow/ test/webapps/drt... To: [email protected] Author: crogers Date: Thu Nov 10 23:37:13 2005 New Revision: 332482 URL: http://svn.apache.org/viewcvs?rev=332482&view=rev Log: Fix for http://issues.apache.org/jira/browse/BEEHIVE-1003 : Calling FlowControllerFactory.createPageFlow() outside of page flow request processor and page filter does not initialize controls correctly. tests: drt, bvt in netui (WinXP) Added: beehive/trunk/netui/test/webapps/drt/coreWeb/miniTests/createPageFlow/ beehive/trunk/netui/test/webapps/drt/coreWeb/miniTests/createPageFlow/Controller.java (with props) beehive/trunk/netui/test/webapps/drt/coreWeb/miniTests/createPageFlow/test.jsp (with props) beehive/trunk/netui/test/webapps/drt/src/miniTests/createPageFlow/ beehive/trunk/netui/test/webapps/drt/src/miniTests/createPageFlow/CreatePageFlowServlet.java (with props) beehive/trunk/netui/test/webapps/drt/src/miniTests/createPageFlow/controls/ beehive/trunk/netui/test/webapps/drt/src/miniTests/createPageFlow/controls/Portfolio.java (with props) beehive/trunk/netui/test/webapps/drt/src/miniTests/createPageFlow/controls/PortfolioControl.java (with props) beehive/trunk/netui/test/webapps/drt/src/miniTests/createPageFlow/controls/PortfolioControlImpl.java (with props) beehive/trunk/netui/test/webapps/drt/src/miniTests/createPageFlow/controls/Stock.java (with props) beehive/trunk/netui/test/webapps/drt/testRecorder/tests/CreatePageFlow.xml (with props) Modified: beehive/trunk/netui/src/pageflow/org/apache/beehive/netui/pageflow/internal/JavaControlUtils.java beehive/trunk/netui/test/webapps/drt/coreWeb/WEB-INF/web.xml beehive/trunk/netui/test/webapps/drt/testRecorder/config/testRecorder-tests.xml
