[ http://issues.apache.org/jira/browse/BEEHIVE-1020?page=all ]
Rich Feit updated BEEHIVE-1020:
-------------------------------
Assign To: Carlin Rogers (was: Rich Feit)
Hey Carlin,
Sorry for the delay. This looks great to me. The only thing I'd change is to
add an assert in ScopedRequestImpl.setAttributeMap() that savedAttrs != null
(so you wouldn't have to check for null -- seems like a valid requirement not
to call the method with a null argument). Also, the deprecated
restoreAttributes() could delegate to setAttributeMap(), but that's certainly
not a big deal.
> Move the persisting of ScopedRequest attributes out of the beehive NetUI layer
> ------------------------------------------------------------------------------
>
> Key: BEEHIVE-1020
> URL: http://issues.apache.org/jira/browse/BEEHIVE-1020
> Project: Beehive
> Type: Improvement
> Components: NetUI
> Versions: V1
> Reporter: Carlin Rogers
> Assignee: Carlin Rogers
> Fix For: 1.1
> Attachments: j1020-patch.txt
>
> I plan to modify the ScopedRequest interface in NetUI to move the persisting
> of ScopedRequest attributes out of the beehive NetUI layer.
> I would deprecate the persistAttributes()/restoreAttributes() from
> ScopedRequest interface and replace them with something like
> getAttributeMap()/setAttributeMap(). The new getAttributeMap() method would
> just return the attribute map and setAttributeMap() sets/merges the
> attributes like we do in restoreAttributes(). Then outside the beehive layer
> an implementation would control the actual placement of persisted attributes
> into the session or whatever other persistence location is desired.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
