Chad / Andrew --

 Thanks for the patch and fix -- do we have a test of this in
Controls somewhere?  If not, could we add a JUnit one?

Eddie


On 6/27/06, Chad Schoettger <[EMAIL PROTECTED]> wrote:
Hi Andrew,

Welcome to the Beehive community.   Thanks for the patch, I've applied
and committed it to svn.

One tip for generating patch files:
When possible do your diff to generate the patch from your
<beehive/trunk> directory as this makes it a bit easier to apply.

Thanks again for providing the patch --  hopefully your first of many.

  - Chad

On 6/26/06, Andrew McCulloch (JIRA) <[email protected]> wrote:
>     [ 
http://issues.apache.org/jira/browse/BEEHIVE-206?page=comments#action_12417889 ]
>
> Andrew McCulloch commented on BEEHIVE-206:
> ------------------------------------------
>
> When I use the test attached by James against the attached patch the new 
error message is...
>
>       [apt] 
/dev/svn/beehive/trunk/controls/test/src/units/org/apache/beehive/controls/test/java/property/MemberTypeTest.java:69:
 A value assigned to a control property does not satisfy its constraints. Cause: 
The value, 2007/01/31, assigned to maxValue date constraint property is not in the 
specified format of: EEE, MMM d, ''yy
>       [apt]     private PersonControlBean thisPerson;
>       [apt]                                   ^
>       [apt] 1 error
>
>
> I believe this is the expected error for the attached version of this 
testcase.
>
>
> > control property constraint:AnnotationMemberTypes.Date accept one format
> > ------------------------------------------------------------------------
> >
> >          Key: BEEHIVE-206
> >          URL: http://issues.apache.org/jira/browse/BEEHIVE-206
> >      Project: Beehive
> >         Type: Bug
>
> >   Components: Controls
> >     Versions: V1Beta
> >     Reporter: James Song
> >     Assignee: Chad Schoettger
> >     Priority: Minor
> >  Attachments: MemberTypeTest.java, MemberTypeTest.java, PersonControl.java, 
PersonControl.java, diff-BEEHIVE-206.txt
> >
> > Currently, AnnotationMemberTypes.Date only accept YYYY/MM/DD.
> > There will be cases when user would like to specify the HH:MM, or other 
input format, such as long date format.
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
>    http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see:
>    http://www.atlassian.com/software/jira
>
>

Reply via email to