Thanks Carlin. I will move forward with the intent of always diffing the pageflow validation config files. With a little luck I should have a patch by tomorrow for you to review.
--Andrew On 6/30/06, Carlin Rogers <[EMAIL PROTECTED]> wrote:
Thanks for looking at this Andrew! Appreciate your contributions. My vote would be to always diff the generated page flow validation files. Carlin On 6/30/06, Andrew McCulloch <[EMAIL PROTECTED]> wrote: > > I am working on a patch for BEEHIVE-1118 which involves the order that > form validations are performed. The bug looks like it comes down to the > way > the pageflow-validation-*.xml file is generated. In addition to the three > testRecorder drts that need to change with this fix I am writing a new > compiler bvt test case. > > Currently the compiler bvts only diff the struts-config*.xml files > against expected results. I have a patch to the JUnit class that performs > the file comparisons to make diffing the generated validation files > mandatory (like he struts config files are), however, I wanted to know if > this is the best choice. It would also be easy to modify the test to only > diff the file if an expected result file is present. This would only miss > the case where a validation file is generated unnecessarily. It would > however avoid changing the other compiler bvts that may use Jpf validation > annotations already. Alternatively I could add some sort of flag or > properties file to trigger the diffing of the validation files only when > desired. This choice would be extensible and be easily adjusted to > handled > any other generated files. > > If this seems like a worthwhile change to the netui compiler bvts I > would like to hear how others think it would be best to handle this. My > initial thought is that it would be best to always diff the pageflow > validation files. > > --Andrew > >
