Rajith-- Hey -- something came up this weekend and I am just getting back to this now. My gut is that this type of metadata modification to an API class isn't going to fly (mail about this shortly); since the annogen beans are just generated from the annotations themselves, can we just hand code them to match the JSR-181 annotations?
Will take a look at the patch... Eddie On 7/23/06, Rajith Attapattu <[EMAIL PROTECTED]> wrote:
Eddie, any update on the issue? Regards, Rajith On 7/20/06, Rajith Attapattu <[EMAIL PROTECTED]> wrote: > > Eddie, > > I totally forgot about sending the patch, but finnaly did it today. > Please review it and let me know your comments. > > We still need to figure out the legal issue about adding an annotation to > the spec class. > (Does annogen have a way around without annotatiing the classes, for it to > generate the AnnoBean classes.???) > > > 2.) Generating Annogen beans for meta data > > The annogen task that generates code based on the annotated classes > > seems to have a bug with inner classes. > > For example WebParam.Mode gives compilation errors as it cannot the > > handle the inner class > > So I eidted the generated source file to get it working. (I maybe > wrong > > here...) > > > > This is still an issue :-( > > Regards, > > Rajith > > On 7/11/06, Rajith Attapattu <[EMAIL PROTECTED]> wrote: > > > > Eddie, > > > > oops, didn't think it was that serious about modifying the spec classes. > > But can u please let me know about it. > > > > > > > > >[eko] Not sure I follow this -- let me take a look at it and I'll get > > >back to you. > > I didn't even submit the patch for this part. I will do so. > > Please take a look at it then. > > > > I am really gratefull for your assitance. > > > > Regards, > > > > Rajith > > > > > > On 7/11/06, Eddie O'Neil <[EMAIL PROTECTED]> wrote: > > > > > > Rajith-- > > > > > > Comments on both of your questions below... > > > > > > Eddie > > > > > > > > > > > 1.) Annogen requires you to annotate the annotation classes with > > > the > > > > following annotation > > > > Now are we allowed to modifty the JSR api classes to add the above > > > lines of > > > > code ?? > > > > > > [eko] This is a *great* question :) and probably the first time > > > we've run into this at Apache. If you were asking to add a *method* > > > to a type described in a specification, the answer would be no because > > > > > > we can't change spec classes. Since it's metadata, I don't know the > > > answer -- my gut would be that we can't change the metadata on a > > > specification class, but it's a question worth asking [EMAIL PROTECTED] > > > just to see what folks think. > > > > > > > > > > 2.) Generating Annogen beans for meta data > > > > The annogen task that generates code based on the annotated > > > classes > > > > seems to have a bug with inner classes. > > > > For example WebParam.Mode gives compilation errors as it cannot > > > the > > > > handle the inner class > > > > So I eidted the generated source file to get it working. (I > > > maybe wrong > > > > here...) > > > > > > > > > > [eko] Not sure I follow this -- let me take a look at it and I'll get > > > back to you. > > > > > > > >
