[
https://issues.apache.org/jira/browse/BEEHIVE-1127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Russ Baker updated BEEHIVE-1127:
--------------------------------
Verified that the AP does not throw an AsserionError or a ClassCastException.
Using Carlin's example, I get the following compilation errors with apt:
[apt]
G:\projects\beehiveDist\trunk\netui\test\webapps\drt\src\bugs\b1127\TestBean.java:28:
This value must be a primitive Class, e.g. int.class.
[apt] public String getName() { return name; }
I ran 'ant clean build' from <beehive home>/trunk/netui/test/webapps/drt and
got this result. Verified against SVN 549584. I suggest that this bug be closed.
> No check() phase during the Controller annotation processing for an external
> form bean class and ValidatableProperty
> --------------------------------------------------------------------------------------------------------------------
>
> Key: BEEHIVE-1127
> URL: https://issues.apache.org/jira/browse/BEEHIVE-1127
> Project: Beehive
> Issue Type: Bug
> Components: NetUI
> Affects Versions: 1.0.1
> Reporter: Carlin Rogers
> Assignee: Julie Zhuo
> Fix For: 1.0.2
>
> Attachments: j1127-patch-newAPFactory.txt, j1127-repro.zip
>
>
> The processing of ValidatableProperty annotations in an external form bean
> does not go through the typical check() phase of the
> TwoPhaseCoreAnnotationProcessor. During the Controller annotation processing
> during the check() we run through the FormBeanChecker and specifically the
> ValidateTypeGrammar.onCheck(), for an inner form bean. However, if we have an
> external form bean class, the Controller annotation processing only looks at
> the external form bean during the generate() phase. Any errors in the
> ValidatableProperty annotations of the external form bean will cause
> processing problems without providing the kind user messages during the
> check() phase.
> For example, if you have a ValidateType(type=String.class) you should see a
> message about using a primitive Class, e.g. int.class. However, you will get
> either an AssertionError or without asserts a ClassCastException in
> org.apache.beehive.netui.compiler.genmodel.DefaultValidatorRuleFactory.getFieldRule().
> I will attach a repro case.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
