Hi Poorna, I have a couple of thoughts on the patch you rpovided. I think it will be OK but still leaves the issue that without a new callback a user cannot write their current onDestroy() and know that they will always have a valid contextual services based on a request. In the case of a session timing out and a valueUnbound, the request will still be null. At least this improves the current issue of destroying a page flow when a user moves to another page flow.
I'd recommend that if we introduce these changes, that we don't just make SessionBindingEvent a public inner class of the DeferredSessionStorageHandler (DSSH). The DSSH is an internal class and not designed to be used directly by a developer. Therefor, I'd recommend that if the SessionBindingEvent event is to be made public it no longer be an inner class, and place it in another package other than "internal". Also, is there a need for the call to get the ControlContainerContext instance in the PageFlowManagedObject.destroy() method? I don't think we need it. I'll be away on holiday for a while but can look at this again with you when I return. Thanks for the contribution. Happy new year! Kind regards, Carlin On 12/20/07, Carlin Rogers <[EMAIL PROTECTED]> wrote: > Sorry Poorna, I have not completely looked through the patch. I'll try > to review it later today. A new callback onDestroy(request, session) > sounds reasonable. We definitely need to make sure these changes are > backward compatible. I do not know of any way to create control > container context without requiring a request. > > Kind regards, > Carlin > > On 12/19/07, Poorna Ramasamy <[EMAIL PROTECTED]> wrote: > > Did anyone get a change to look at this? > > > > regards, > > ~Poorna > > > > > > > > -----Original Message----- > > From: Poorna Ramasamy > > Sent: Wednesday, December 12, 2007 10:24 PM > > To: Beehive Developers > > Cc: Carlin Rogers > > Subject: RE: BEEHIVE-1094 > > > > Attached diff is the new solution I have in my mind now. That is, > > request is being tracked right from where the pageflow is removed from > > session using the SessionBindingEvent. At the destroy method if request > > is available, context is created or else onDestroy(session) is called > > without context. > > > > But I feel, with this approach, customers would not be certain about the > > context being associated with onDestroy(session). If session > > invalidation occurs, onDestroy(session) will be called without context. > > So to overcome this, I feel, a new callback onDestroy(request, session) > > is required here. Does this sound reasonable? Or if there is a way in > > which I can create control container context without requiring "request" > > object, please let me know. > > > > regards, > > ~Poorna > > > > > > Notice: This email message, together with any attachments, may contain > > information of BEA Systems, Inc., its subsidiaries and affiliated > > entities, that may be confidential, proprietary, copyrighted and/or > > legally privileged, and is intended solely for the use of the individual or > > entity named in this message. If you are not the intended recipient, and > > have received this message in error, please immediately return this by > > email and then delete it. > > >
