[
https://issues.apache.org/jira/browse/BIGTOP-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13478100#comment-13478100
]
Johnny Zhang commented on BIGTOP-740:
-------------------------------------
@Roman, thanks for comments. I agree hard-coding patterns into groovy is not a
good option.
How about we check in a file with file content diff we want to ignore in a
external location, let's call it to-be-ignored.diff And during the file content
test, all runtime diff included in this diff got ignored. In this way, we don't
have to hard-coding any patterns in code, and it is also easy to maintain it
(just make diff, and checkin it). The plus benefit of this method is it also
make it easy to take care file content diff introduced by pkg like hue-common
(the python thing).
> improve the package file content tests to ignore platform specific file names
> -----------------------------------------------------------------------------
>
> Key: BIGTOP-740
> URL: https://issues.apache.org/jira/browse/BIGTOP-740
> Project: Bigtop
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.5.0
> Reporter: Johnny Zhang
> Assignee: Johnny Zhang
> Fix For: 0.5.0
>
> Attachments: BIGTOP_740.txt
>
>
> right now the package file content test recognize below files are different
> and report errors
> {noformat}
> /usr/lib/hadoop-0.20-mapreduce/lib/native/Linux-amd64-64 (in centos5_x64)
> /usr/lib/hadoop-0.20-mapreduce/lib/native/Linux-i386-32 (in centos6_x32)
> ......
> /usr/lib64/libhdfs.so (in centos5_x64)
> /usr/lib/libhdfs.so (in centos6_x32)
> {noformat}
> the test should ignore those kind of difference, as they are platform
> specific name.
> there is another type of file name difference we should ignore is the
> dependency version. For example, the hue-common package detect the python
> version installed on the OS and install correspond version of python related
> file, for example
> {noformat}
> /usr/share/hue/build/env/bin/pip-2.4 (in centos5)
> /usr/share/hue/build/env/bin/pip-2.6 (in centos6)
> {noformat}
> those diff also should be ignored.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
