[
https://issues.apache.org/jira/browse/BIGTOP-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491146#comment-13491146
]
Erick Erickson commented on BIGTOP-736:
---------------------------------------
Roman:
I don't see BIGTOP-738 in the patch attached to this JIRA from Oct 30. That
patch uses Lucene directly to manipulate an index, can we include that?
I'll upload a patch for 739 (embedded Solr server) momentarily, assuming my
internet doesn't go wonky. That test needs access to SOLR_HOME directory for
the example in the stock distro, on my machine for instance it'd be
/Users/Erick/apache/4x/solr/example/solr. There's a TODO in the embedded test
(739). I notice what looks like setting SOLR_URL as an environment variable,
can we do something similar for SOLR_HOME?
I've also uploaded a new patch for 738 that should be in the right package.
But that's really an aside. I guess I'm not sure how far to take creating
tests. At this point we've hit a bunch of major units of Solr, although
extremely shallowly. My personal feeling is that we should just get this in
place then expanding them as needed.
The tests so far are a bit fragile, just something to keep in mind. They use
the example installation and manipulate the index there, attempting to clean
things up tidily. All well and good, but that makes the state of the index
files suspect with more extensive tests. The regular Solr tests have a
complicated way of creating temp directories to bypass this problem, but again
I think that's for "the future", if we find we need more robustness in the
tests. My personal feeling is that we're testing "if everything goes right"
here, not "can we handle all the strange cases that could exist".
So lets add the two JIRAs (738 and 739) and I'll close all that series.
Thanks so much for doing the hard parts!
> When Solr is integrated, we'll need some tests.
> -----------------------------------------------
>
> Key: BIGTOP-736
> URL: https://issues.apache.org/jira/browse/BIGTOP-736
> Project: Bigtop
> Issue Type: Sub-task
> Components: Tests
> Reporter: Erick Erickson
> Assignee: Roman Shaposhnik
> Priority: Minor
> Fix For: 0.5.0
>
> Attachments: BIGTOP-736.patch.txt, solr_tests.zip, TestSimple.groovy
>
>
> I've put together some tests as a skeletal place to start with Solr tests.
> I'll add a zip file in a few minutes. They do a really simple ping, one
> indexes a few documents and searches, and one verifies that we can get to the
> filterCache statistics.
> This is very preliminary. The zipped up tests run against a locally-built
> Solr, NOT the one that will be packaged with BigTop. And I haven't a clue how
> to integrate them with the actual package, (any hints welcome). This is meant
> as a starting place.
> Of course to be done for real we'll need to create an actual patch, but I'm
> guessing we'll need to sequence that after the base Solr gets into the
> packaging, the zip file is meant as a record to build upon when we actually
> get this all together.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
