[ 
https://issues.apache.org/jira/browse/BIGTOP-838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13569432#comment-13569432
 ] 

Harsh J commented on BIGTOP-838:
--------------------------------

Good points Roman; I hadn't considered the /etc/default/hadoop* when filing 
this.

Indeed that acts in ways similar to hadoop-env.sh (does it also allow heap size 
control, etc., which is primarily what people modify it for?), but its not very 
discoverable.

Having an empty file is worth it (and is what I filed for as well, sorry I did 
not elaborate early) - 'hadoop-env.sh' is written about in several guides 
online as a place to set stuff like specific daemon heap size, etc.; which a 
new Bigtop package user may easily miss?
                
> Both conf.empty and conf.pseudo packages don't seem to include a sample 
> hadoop-env.sh file
> ------------------------------------------------------------------------------------------
>
>                 Key: BIGTOP-838
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-838
>             Project: Bigtop
>          Issue Type: Improvement
>          Components: General
>    Affects Versions: 0.5.0
>            Reporter: Harsh J
>              Labels: conf, package
>
> As noticeable on 
> https://git-wip-us.apache.org/repos/asf?p=bigtop.git;a=tree;f=bigtop-packages/src/common/hadoop/conf.pseudo;h=b0ca9e629fb6d51fb83c61f1354f4bbad155e3af;hb=HEAD,
>  we should include a base hadoop-env.sh (and maybe a yarn-env.sh as well).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to