[
https://issues.apache.org/jira/browse/BIGTOP-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13585517#comment-13585517
]
Konstantin Boudnik edited comment on BIGTOP-852 at 2/24/13 10:41 PM:
---------------------------------------------------------------------
Wow, this is a mess. I would recommend to move to a separate helper script -
this kind of functionality is clearly goes too far beyond preparations of the
directories in HDFS. E.g. this exposes the knowledge about Oozie dependencies
to some tiny script that only has to do a bunch of mkdirs. In fact, I would
even insist on removing this part from the script in question.
That's a real issue, unlike the dups of 3 mkdir commands we've been arguing
over elsewhere.
was (Author: cos):
Wow, this is mess. I would recommend to move to a separate helper script -
this kind of functionality is clearly goes too far beyond preparations of the
directories in HDFS. E.g. this exposes the knowledge about Oozie dependencies
to some tiny script that only has to do a bunch of mkdirs.
That's a real issue, unlike the dups of 3 mkdir commands we've been arguing
over elsewhere.
> Improve HDFS helper script
> --------------------------
>
> Key: BIGTOP-852
> URL: https://issues.apache.org/jira/browse/BIGTOP-852
> Project: Bigtop
> Issue Type: Bug
> Components: Deployment
> Affects Versions: 0.6.0
> Reporter: Mark Grover
> Fix For: 0.6.0
>
>
> There are a few things that can be improved regarding the HDFS helper script
> introduced by BIGTOP-547. Some of these issues have been discussed in
> BIGTOP-637.
> 1. The script seems to create user directories for users "root" and "jenkins"
> but not the current user running the script. I think it will be a good idea
> to add in the script the commands to create the /user/$USER directory in
> HDFS. Of course, we should be careful in case the user running the command is
> root or jenkins, in that case a simple mkdir command would throw error given
> that those directories already exist.
> 2. The script uses sudo which requires login shell. However, login shells are
> not available for certain use cases like init scripts. Consequently, we
> should consider using su instead.
> 3. Look into how the helper script can be made faster
> Folks, please feel free to add/edit if there is something I missed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
