[
https://issues.apache.org/jira/browse/BIGTOP-848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13599750#comment-13599750
]
Bruno Mahé edited comment on BIGTOP-848 at 3/12/13 6:56 AM:
------------------------------------------------------------
Thanks a lot for the update. But I still do have the same comments as before.
None of the issues I noted were addressed except the git url:
* Please comment out the 3 new lines in bigtop.mk and change the git URL to the
Apache git repo. By default Apache Bigtop should build components from their
releases, and not their master/trunk branch
* if $($(PKG)_GIT_LOC) is not defined, it should exit -1, not just exit. We
should always signal errors
* Why not using the "git archive" which already does all the archiving for you?
If we can reduce the complexity and room for error of the code, we should do so.
I would love to be able to check in this patch since it is almost done, but we
need first to get these issues addressed.
was (Author: bmahe):
Thanks a lot for the update. But I still do have the same comments as
before.
None of the issues I noted were addressed except the git url:
* Please comment out the 3 new lines in bigtop.mk and change the git URL to the
Apache git repo.
* if $($(PKG)_GIT_LOC) is not defined, it should exit -1, not just exit.
* Why not using the "git archive" which already does all the archiving for you?
> Allow to build stack on top of an arbitrary Hadoop SHA
> ------------------------------------------------------
>
> Key: BIGTOP-848
> URL: https://issues.apache.org/jira/browse/BIGTOP-848
> Project: Bigtop
> Issue Type: Improvement
> Components: General
> Affects Versions: 0.5.0
> Reporter: Konstantin Boudnik
> Fix For: 0.6.0
>
> Attachments: 0001-BIGTOP-848-git-support-maybe.patch
>
>
> For the ease of experimenting and doing one-off stack builds, which was
> always the objective of the founding idea of this project, I would like to
> have a way to build a stack from an arbitrary SHA of Hadoop git.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
