> On March 15, 2013, 12:18 a.m., Jarek Cecho wrote: > > BIGTOP-805.3.patch, line 1 > > <https://reviews.apache.org/r/9264/diff/7/?file=270862#file270862line1> > > > > Can we remove this entire file? :-) > > Sean Mackrory wrote: > It took me a little while to realize that I had added the previous patch, > and that you weren't suggesting I remove catalina.properties :)
Och sorry, I should have been more specific. > On March 15, 2013, 12:18 a.m., Jarek Cecho wrote: > > bigtop-packages/src/deb/sqoop/control, line 26 > > <https://reviews.apache.org/r/9264/diff/7/?file=270876#file270876line26> > > > > Can we say "...and Hadoop ecosystem"? > > Sean Mackrory wrote: > I like that - I changed the short descriptions in the .spec file for RPMs > too (long descriptions still use the terms "HDFS" and "relational databases" > for specificity). Thank you! - Jarek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9264/#review17930 ----------------------------------------------------------- On March 14, 2013, 11:55 p.m., Sean Mackrory wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9264/ > ----------------------------------------------------------- > > (Updated March 14, 2013, 11:55 p.m.) > > > Review request for bigtop and Jarek Cecho. > > > Description > ------- > > This patch upgrades Sqoop from the 1.x series to the 2.x series (that is > currently actually at 1.99.1). The new architecture consists of a lightweight > client and a centralized server. I've also adapted the init script template > used by the Hadoop services and used it for sqoop-server. It's available for > all subsequent components that want to make use of it - should make it easier > to solve common bugs and be consistent. > > > This addresses bug BIGTOP-805. > https://issues.apache.org/jira/browse/BIGTOP-805 > > > Diffs > ----- > > BIGTOP-805.3.patch PRE-CREATION > bigtop-packages/src/common/sqoop/catalina.properties PRE-CREATION > bigtop-packages/src/common/sqoop/do-component-build 42a2442 > bigtop-packages/src/common/sqoop/install_sqoop.sh 771931a > bigtop-packages/src/common/sqoop/setenv.sh PRE-CREATION > bigtop-packages/src/common/sqoop/sqoop-metastore.sh ab22ef3 > bigtop-packages/src/common/sqoop/sqoop-metastore.sh.suse bcc1fef > bigtop-packages/src/common/sqoop/sqoop-server.sh PRE-CREATION > bigtop-packages/src/common/sqoop/sqoop-server.svc PRE-CREATION > bigtop-packages/src/common/sqoop/sqoop.default PRE-CREATION > bigtop-packages/src/common/sqoop/sqoop.properties PRE-CREATION > bigtop-packages/src/common/sqoop/sqoop.sh PRE-CREATION > bigtop-packages/src/deb/sqoop/changelog 547ed02 > bigtop-packages/src/deb/sqoop/compat 7f8f011 > bigtop-packages/src/deb/sqoop/control dcc6106 > bigtop-packages/src/deb/sqoop/copyright ec176a9 > bigtop-packages/src/deb/sqoop/rules 7992dcd > bigtop-packages/src/deb/sqoop/sqoop-client.install PRE-CREATION > bigtop-packages/src/deb/sqoop/sqoop-metastore.postinst b8b6635 > bigtop-packages/src/deb/sqoop/sqoop-metastore.preinst 76cfb26 > bigtop-packages/src/deb/sqoop/sqoop-server.install PRE-CREATION > bigtop-packages/src/deb/sqoop/sqoop-server.postinst PRE-CREATION > bigtop-packages/src/deb/sqoop/sqoop.install PRE-CREATION > bigtop-packages/src/deb/sqoop/sqoop.postinst 37cae7e > bigtop-packages/src/deb/sqoop/sqoop.preinst PRE-CREATION > bigtop-packages/src/deb/sqoop/sqoop.prerm b9a25a5 > bigtop-packages/src/rpm/sqoop/SPECS/sqoop.spec 9774326 > bigtop-packages/src/templates/init.d.tmpl PRE-CREATION > bigtop.mk 96f2257 > package.mk 8e45771 > > Diff: https://reviews.apache.org/r/9264/diff/ > > > Testing > ------- > > I've tested this exact patch on Fedora 17 and Ubuntu Precise, and previous > iterations (without significant differences) on RHEL 5, RHEL 6, and Ubuntu > Lucid. > > > Thanks, > > Sean Mackrory > >
