[
https://issues.apache.org/jira/browse/BIGTOP-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13614891#comment-13614891
]
Konstantin Boudnik commented on BIGTOP-852:
-------------------------------------------
Love it! +1
My understanding is the tar file will contain an empty directory structure of
everything we'll need in the HDFS right?
I only have some doubts about this line
{{ fs.setOwner(file, entry.getUserName(), entry.getGroupName());}}
for two reasons:
- ownership will totally depends on the way the tar has been created
- permissions of the files/directories aren't clearly set. Are preservation of
original permissions guaranteed by untar?
very minor: usage check calls {{println}} wheres while loop is calling
{{System.out.printf}} instead of its shortcut {{printf}}
> Improve HDFS helper script
> --------------------------
>
> Key: BIGTOP-852
> URL: https://issues.apache.org/jira/browse/BIGTOP-852
> Project: Bigtop
> Issue Type: Sub-task
> Components: Deployment
> Affects Versions: 0.6.0
> Reporter: Mark Grover
> Assignee: Mark Grover
> Fix For: 0.6.0
>
> Attachments: untarHdfs.groovy
>
>
> There are a few things that can be improved regarding the HDFS helper script
> introduced by BIGTOP-547. Some of these issues have been discussed in
> BIGTOP-637.
> 1. The script seems to create user directories for users "root" and "jenkins"
> but not the current user running the script. I think it will be a good idea
> to add in the script the commands to create the /user/$USER directory in
> HDFS. Of course, we should be careful in case the user running the command is
> root or jenkins, in that case a simple mkdir command would throw error given
> that those directories already exist.
> 2. The script uses sudo which requires login shell. However, login shells are
> not available for certain use cases like init scripts. Consequently, we
> should consider using su instead.
> 3. Look into how the helper script can be made faster
> Folks, please feel free to add/edit if there is something I missed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
