[
https://issues.apache.org/jira/browse/BIGTOP-732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13630249#comment-13630249
]
Roman Shaposhnik commented on BIGTOP-732:
-----------------------------------------
Looks good and I really would like to have it for Bigtop 0.6.0. A couple of
points though:
# it seems that you're only using the new template for the regionservers, yet
it has all sorts of 'if [ "@HBASE_DAEMON@" == "master" ] ; then' code blocks.
Am I missing something?
# we should probably simplify Autodetect JAVA_HOME block since now we have
standardized on a common location for bigtop-detect-javahome
# The block of code '# Our default HBASE_HOME, HBASE_PID_DIR and
HBASE_CONF_DIR' likely belongs to /etc/default/hbase (only then the following
if statement is actually useful)
# Would it be completely unreasonable to also make FIRST_PORT/FIRST_INFO_PORT
tweakable for both types of daemons in /etc/default/hbase (via calling them
MASTER_FIRST_PORT, REGIONSERVER_FIRST_PORT, etc)
# does the following ever yield false? 'if [ "@HBASE_DAEMON@" !=
"regionserver" -a "@HBASE_DAEMON@" != "master" ] ; then'
And my final question -- does this patch change the default behaviour/output
for the case of a single daemon per node?
> Support running multiple HBase region servers
> ---------------------------------------------
>
> Key: BIGTOP-732
> URL: https://issues.apache.org/jira/browse/BIGTOP-732
> Project: Bigtop
> Issue Type: New Feature
> Reporter: Sean Mackrory
> Assignee: Sean Mackrory
> Attachments:
> 0001-BIGTOP-732.-Support-running-multiple-HBase-region-se.patch,
> BIGTOP-732.patch.1, BIGTOP-732.patch.2, BIGTOP-732.patch.3,
> BIGTOP-732.patch.4, BIGTOP-732.patch.5
>
>
> Previously on the mailing list I submitted the idea of supporting multiple
> region server daemons on the same system. This can be done using the
> local-regionservers.sh and local-masters.sh scripts that we remove from our
> packaging (see BIGTOP-503), but apparently running multiple region servers in
> production can be useful. It should be possible through init scripts, and it
> should play nice with the more traditional use case.
> The modified init script template should make it safe and intuitive to run
> multiple region servers and masters on the same system, but only the
> regionserver package is using the new template - I don't know of a good
> reason to run multiple masters in production. Using the init script as before
> will control a single region-server daemon EXACTLY as it did before. If you
> specify numbers as additional parameters, you can control multiple daemons:
> {noformat}
> service hbase-regionserver start # Starts a single region server daemon, as
> before
> (all other commands, with no additional parameters, will work as before)
> service hbase-regionserver start 1 2 3 4 # Starts a single region server
> daemon
> service hbase-regionserver restart 2 4 # Restarts the even daemons
> service hbase-regionserver stop 1 3 # Stops the odd daemons
> service hbase-regionserver stop # Stops all region servers in any mode of
> operation
> service hbase-regionserver restart 1 2 3 # Stops all region servers, then
> starts these 3
> {noformat}
> I can see a case being made for changing the behavior of the stop and restart
> commands - so let me know if you disagree with the path I took. The log files
> and pid files get put in the same directory, but are also numbered according
> to their offset. The force-stop and force-reload command should also work as
> expected. When running a single daemon you can't start multiple daemons, and
> vice-versa. As recommended by Bruno for LSB-compliance and ease of
> administration, you can specify the offsets in
> /etc/hbase/conf/regionserver_offsets instead of on the command-line.
> Specifying offsets on the command-line anyway will override the file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
