[
https://issues.apache.org/jira/browse/BIGTOP-973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13650457#comment-13650457
]
Konstantin Boudnik commented on BIGTOP-973:
-------------------------------------------
Also, this fail-early approach will guarantee that we are not missing version
update when Oozie is upgraded.
> Improve error diagnostics when sed'ing Hadoop version in Oozie package
> ----------------------------------------------------------------------
>
> Key: BIGTOP-973
> URL: https://issues.apache.org/jira/browse/BIGTOP-973
> Project: Bigtop
> Issue Type: Improvement
> Components: RPM
> Affects Versions: 0.5.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.6.0
>
> Attachments: BIGTOP-973.patch
>
>
> There's no good diagnostics when {{do-component-build}} dynamically replaced
> the target Hadoop version. If the "to be replaced" version isn't present in
> the Oozie pom files, the error might not surfaced until later or at all: mvn
> will simply pull in incorrect versions of Hadoop libs. case in point: when
> doing something like this
> {noformat}
> sed -i.orig -e "s#2.0.2-alpha#${HADOOP_VERSION}#"
> ${WORKDIR}/hadooplibs/hadoop-distcp-2/pom.xml
> {noformat}
> sed will exit successfully even if no replacement took place. We need to
> guarantee to fail early.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
