[ 
https://issues.apache.org/jira/browse/BIGTOP-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703565#comment-13703565
 ] 

Mark Grover commented on BIGTOP-811:
------------------------------------

Sean,
This looks good to me overall.

A few minor suggestions:
1. The patch doesn't apply cleanly anymore. Can you please update it?
2. I would still personally like to see a template entry for how to override 
BIGTOP_CLASSPATH in bigtop-utils.default 
(https://github.com/apache/bigtop/blob/master/bigtop-packages/src/common/bigtop-utils/bigtop-utils.default)
May be something like:
{code}
# Override Bigtop classpath for including common jars (e.g. database 
connectors, etc.) in classpath of various components of Bigtop distribution. 
Only needed for including jars outside of /var/lib/bigtop.
# export BIGTOP_CLASSPATH
{code}
What do you think?

It's also worth pointing out somewhere in code/comment/documentation that 
{{BIGTOP_CLASSPATH}} currently only is used by Hive. Sqoop, Oozie bypass and 
directly add things to tomcat's classpath without observing what's in 
BIGTOP_CLASSPATH.
                
> Add /var/lib/bigtop as a location to install SQL connectors and other plug-ins
> ------------------------------------------------------------------------------
>
>                 Key: BIGTOP-811
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-811
>             Project: Bigtop
>          Issue Type: New Feature
>            Reporter: Sean Mackrory
>            Assignee: Sean Mackrory
>            Priority: Critical
>             Fix For: 0.7.0
>
>         Attachments: 
> 0001-BIGTOP-811.-Add-var-lib-bigtop-as-a-location-to-inst.patch, 
> 0001-BIGTOP-811-Auto-detect-common-add-on-JARs-like-SQL-c.patch, 
> 0001-BIGTOP-811.-Auto-detect-MySQL-Java-connector.patch, 
> 0001-BIGTOP-811.-Auto-detect-MySQL-Java-connector.patch, BIGTOP-811.2.patch
>
>
> For components that require the installation of additional artifacts that 
> Bigtop cannot distribute (due to license incompatability or other issues), 
> Bigtop should provide both a standardized location to which the artifacts can 
> be installed, and the ability to auto-detect the locations to which they may 
> already be installed.
> Specifically, Sqoop and Hive (and possibly other components) require the 
> installation of the MySQL-Java connector when using MySQL for imports, 
> exports, or metadata storage. This needs to be done by copying the JAR to a 
> directory that is already in the classpath for those components (such as 
> /usr/lib/sqoop/lib and /usr/lib/hive/lib). Some repositories distribute 
> packages that install the jar to /usr/share/java.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to