[
https://issues.apache.org/jira/browse/BIGTOP-1034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13721791#comment-13721791
]
Mark Grover commented on BIGTOP-1034:
-------------------------------------
Henry, your patch looks good.
May I request you to provide a patch via git format-patch, please?
This the workflow I personally follow:
1. Ensure that you have all of your change as 1 commit which has the correct
commit message - something like BIGTOP-1034: Custom user's home directory's
creation fails in init-hdfs.sh
2. Then run a command like: git format-patch HEAD^..HEAD --stdout >
BIGTOP-1034.2.patch
3. Upload the BIGTOP-1034.2.patch file to this JIRA
git format-patch works better for all of us because it's easy to attribute the
commit to you in the git history since it contains your name and email address.
> Custom user's home directory's creation fails in init-hdfs.sh
> -------------------------------------------------------------
>
> Key: BIGTOP-1034
> URL: https://issues.apache.org/jira/browse/BIGTOP-1034
> Project: Bigtop
> Issue Type: Bug
> Components: Debian, RPM
> Affects Versions: 0.6.0
> Reporter: Mark Grover
> Assignee: Mark Grover
> Labels: hackathon-7-2013
> Fix For: 0.7.0
>
> Attachments: BIGTOP-1034.1.patch, init-hdfs.patch
>
>
> The init-hdfs.sh script has {{set -ex}} at the top for a good reason.
> However, the script itself when creating a custom user's home directory on
> HDFS, does a {{ls}} to see if the directory already exists:
> https://github.com/apache/bigtop/blob/master/bigtop-packages/src/common/hadoop/init-hdfs.sh#L91
> This fails if the directory doesn't exist which makes the entire script fail.
> This check could be enclosed so it doesn't make the script fail.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
